Fix category signedness check in manual-dns-manage.fif #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a check in manual DNS management Fift script, that verifies the category number as an signed `int256` instead of unsigned `uint256,` that this number is actually treated as later in the code (`256 u,`). Importance of this fix is that the common `"wallet"H` category hash is `0xe8d44050873dba865aa7c170ab4cce64d90839a34dcfd6cf71d14e0205443b1b`, and therefore has a high bit set - therefore without this fix it is impossible to create subdomains in the `"wallet"H` category.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a check in manual DNS management Fift script, that verifies the category number as an signed
int256instead of unsigneduint256,that this number is actually treated as later in the code (256 u,).Importance of this fix is that the common
"wallet"Hcategory hash is0xe8d44050873dba865aa7c170ab4cce64d90839a34dcfd6cf71d14e0205443b1b, and therefore has a high bit set - therefore without this fix it is impossible to create subdomains in the"wallet"Hcategory.