Add feature flag for deriving serde macros. The default is off. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcginty
suggested changes
Dec 5, 2019
webrtc-audio-processing-sys/build.rs
Outdated
| .replace_all(&contents, "#[derive($d, PartialEq)] pub struct") | ||
| .to_string(); | ||
|
|
||
| #[cfg(feature = "derive_serde")] |
There was a problem hiding this comment.
if cfg!(feature = "derive_serde") {
...
}
webrtc-audio-processing-sys/build.rs
Outdated
| File::create(&binding_file)?.write_all(new_binding_contents.as_bytes())?; | ||
| // Add PartialEq to structs. | ||
| // Used for checking partial equality of `Config` struct. | ||
| contents = Regex::new(r"#\s*\[\s*derive\s*\((?P<d>[^)]+)\)\s*\]\s*pub\s*struct")? |
There was a problem hiding this comment.
maybe best to add a comment to the bindgen issue that is requesting the ability to inject these types of things directly without regex.
There was a problem hiding this comment.
There was more relevant issue already existing. I just upvoted a comment there.
rust-lang/rust-bindgen#1089
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround. Ideally bindgen supports adding custom derive macros, esp common ones like serde.
Some discussion here:
rust-lang/rust-bindgen#1089
rust-lang/rust-bindgen#1301