-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for loongarch64 #151
Conversation
Add testcases for this in https://github.com/tonistiigi/binfmt/blob/master/.github/workflows/ci.yml#L114-L132 as well. @crazy-max Is there anything else that needs to be enabled for CI side? |
Add debian image running test with the Loongarch architecture |
@crazy-max Thanks! |
I don't think so 👍 |
Seems test fails for loong64: https://github.com/tonistiigi/binfmt/actions/runs/7271830266/job/19818345215?pr=151#step:6:138
|
Change the running test There are some problems with the debian images libc.so under the cr.Loongnix.cn . After manual testing, the alpine image under the website can successfully output the Or use yangzewei2023 can also complete the test In order to unify, use yangzewei2023 here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@yzewei Can you squash your commits please? |
OK |
scripts/configure_qemu.sh
Outdated
@@ -34,6 +34,9 @@ if [ -z "$QEMU_TARGETS" ]; then | |||
if [ "$arch" != "mips64" ] ; then | |||
QEMU_TARGETS="$QEMU_TARGETS mips64-linux-user" | |||
fi | |||
if [ "$arch" != "loongarch64" ] ; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the GOARCH
formatting, so should be loong64.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Signed-off-by: yzewei <yangzewei@loongson.cn>
I'm very sorry, due to my operational errors, the last PR failed, re -submitted to complete the Loongarch support work.
The LoongArch architecture (LoongArch) is an Instruction Set Architecture (ISA) that has a RISC style.
@crazy-max @tonistiigi