Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filling in state of art section #9

Merged
merged 35 commits into from
Mar 9, 2023
Merged

Filling in state of art section #9

merged 35 commits into from
Mar 9, 2023

Conversation

staniewzki
Copy link
Collaborator

No description provided.

thesis-en.tex Outdated Show resolved Hide resolved
@tonowak
Copy link
Owner

tonowak commented Feb 23, 2023

@obi1kenobi we can't use Draft PRs in this repo, so we're using "draft" in the title to indicate that the PR is not ready for review.

@staniewzki staniewzki changed the title [draft] Filling in state of art section Filling in state of art section Feb 28, 2023
Copy link
Owner

@tonowak tonowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely written!

I have quite a few of suggestions, but most of them are suggestions about commas (which I did "by feel" and I might be wrong in some cases -- if you think some of my suggestions are wrong, feel free to mention it) and suggestions where I'm proposing alternatives (again, you don't have to accept all of them), so I hope that my suggestions won't be time-consuming.

thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
@obi1kenobi
Copy link
Collaborator

Here are some interesting recent events that might be useful in your thesis.

This PR had a semver "near miss" and if not for cargo-semver-checks would probably have shipped a semver break. It's pretty clear from the context that the maintainers were not expecting their type to stop being UnwindSafe and were likely not even aware that their type was publicly UnwindSafe to start with.

The same project also unintentionally made a public type Sync and now that's a semver hazard for the future as reverting it is semver-major:

But there is a hazard for a future semver violation that you may not have noticed: the Behaviour type is now Sync (as of the bisected commit), and semver requires a major version if it ever stops being Sync. This is a good example of something that might be a good warn-level API evolution lint for the future.

thesis-en.tex Outdated Show resolved Hide resolved
Copy link
Owner

@tonowak tonowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to close the resolved conversations. If I missed one, please just write a comment there so I can verify it and close it.

thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
staniewzki and others added 9 commits March 8, 2023 14:24
Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com>
Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com>
Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com>
Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com>
Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com>
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com>
Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com>
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
tonowak and others added 2 commits March 9, 2023 08:36
Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com>
thesis-en.tex Outdated Show resolved Hide resolved
Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com>
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
Copy link
Collaborator

@SmolSir SmolSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BAAAANG

thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
often changes along with the development of the language, which makes maintenance time-consuming.

The second existing tool is \texttt{rust-semverver}, which focuses on
the metadata present in the rust-specific rlib binary static library format.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the metadata present in the rust-specific rlib binary static library format.
the metadata present in the rust-specific rlib binary static library format.

This line is a bit exhausting to understand, some simplifying maybe?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, I just want to merge this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Collaborator

@SmolSir SmolSir Mar 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my what have I done .ru

thesis-en.tex Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Show resolved Hide resolved
tonowak and others added 19 commits March 9, 2023 09:31
Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com>
Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com>
Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com>
Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com>
Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com>
Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com>
Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com>
Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com>
Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com>
Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com>
Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com>
Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com>
Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com>
Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com>
Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com>
Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com>
thesis-en.tex Outdated Show resolved Hide resolved
thesis-en.tex Outdated Show resolved Hide resolved
@tonowak tonowak merged commit 9206efd into main Mar 9, 2023
@staniewzki staniewzki deleted the state-of-art branch April 27, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants