Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ampersands look like the number "6" #209

Closed
broady opened this issue Jul 14, 2016 · 7 comments
Closed

Ampersands look like the number "6" #209

broady opened this issue Jul 14, 2016 · 7 comments

Comments

@broady
Copy link

broady commented Jul 14, 2016 •
edited
Loading

cnv2afwumaaspdt
@tonsky
Copy link
Owner

tonsky commented Jul 16, 2016

Looks more like number 8 for me

@MadcapJake
Copy link

That's how the ampersand looks in Fira Mono

@aaaxx
Copy link

aaaxx commented Jul 17, 2016 •
edited
Loading

Ampersand itself is already a ligature (how ironic) of the Latin word “et”, meaning “and”. Some font designs reflect that, making it look like a recognizable “Et”.

@tonsky tonsky closed this as completed Aug 30, 2016
@pforhan
Copy link

pforhan commented May 22, 2017

I understand it's based off the original, but I concur, this is lower in readability than other fonts, the opposite of what's desired.

@wopian wopian mentioned this issue May 30, 2018
Closed
Losangelosgenetics pushed a commit to Losangelosgenetics/FiraCode that referenced this issue Mar 12, 2020
@dependabot-support
Merge tonsky#199
a32e137 
199: Update rack-test requirement from ~> 0.6 to ~> 1.1 r=bronzdoc a=dependabot[bot]

Updates the requirements on [rack-test](https://github.com/rack-test/rack-test) to permit the latest version.
<details>
<summary>Release notes</summary>

*Sourced from [rack-test's releases](https://github.com/rack-test/rack-test/releases).*

> ## v1.1.0
> ## 1.1.0 / 2018-07-21
> 
> * Breaking changes:
>   * None
> 
> * Minor enhancements / new functionality:
>   * [GitHub] Added configuration for Stale (Per Lundberg [tonsky#232](https://github-redirect.dependabot.com/rack-test/rack-test/issues/232))
>   * `follow_direct`: Include `rack.session.options` (Mark Edmondson [tonsky#233](https://github-redirect.dependabot.com/rack-test/rack-test/issues/233))
>   * [CI] Add simplecov (fatkodima [tonsky#227](https://github-redirect.dependabot.com/rack-test/rack-test/issues/227))
> 
> Bug fixes:
>   * Follow relative locations correctly. (Samuel Williams [tonsky#230](https://github-redirect.dependabot.com/rack-test/rack-test/issues/230))
</details>
<details>
<summary>Changelog</summary>

*Sourced from [rack-test's changelog](https://github.com/rack-test/rack-test/blob/master/History.md).*

> ## 1.1.0 / 2018-07-21
> 
> * Breaking changes:
>   * None
> 
> * Minor enhancements / new functionality:
>   * [GitHub] Added configuration for Stale (Per Lundberg [tonsky#232](https://github-redirect.dependabot.com/rack-test/rack-test/issues/232))
>   * follow_direct: Include rack.session.options (Mark Edmondson [tonsky#233](https://github-redirect.dependabot.com/rack-test/rack-test/issues/233))
>   * [CI] Add simplecov (fatkodima [tonsky#227](https://github-redirect.dependabot.com/rack-test/rack-test/issues/227))
> 
> Bug fixes:
>   * Follow relative locations correctly. (Samuel Williams [tonsky#230](https://github-redirect.dependabot.com/rack-test/rack-test/issues/230))
> 
> ## 1.0.0 / 2018-03-27
> 
> * Breaking changes:
>   * Always set CONTENT_TYPE for non-GET requests
>     (Per Lundberg [tonsky#223](https://github-redirect.dependabot.com/rack-test/rack-test/issues/223))
> 
> * Minor enhancements / bug fixes:
>   * Create tempfile using the basename without extension
>     (Edouard Chin [tonsky#201](https://github-redirect.dependabot.com/rack-test/rack-test/issues/201))
>   * Save `session` during `follow_redirect!`
>     (Alexander Popov [tonsky#218](https://github-redirect.dependabot.com/rack-test/rack-test/issues/218))
>   * Document how to use URL params with DELETE method
>     (Timur Platonov [tonsky#220](https://github-redirect.dependabot.com/rack-test/rack-test/issues/220))
> 
> ## 0.8.3 / 2018-02-27
> 
> * Bug fixes:
>   * Do not set Content-Type if params are explicitly set to nil
>     (Bartek Bułat [tonsky#212](https://github-redirect.dependabot.com/rack-test/rack-test/issues/212)). Fixes [tonsky#200](https://github-redirect.dependabot.com/rack-test/rack-test/issues/200).
>   * Fix `UploadedFile#new` regression
>     (Per Lundberg [tonsky#215](https://github-redirect.dependabot.com/rack-test/rack-test/issues/215))
> 
> * Minor enhancements
>   * [CI] Test against Ruby 2.5 (Nicolas Leger [tonsky#217](https://github-redirect.dependabot.com/rack-test/rack-test/issues/217))
> 
> ## 0.8.2 / 2017-11-21
> 
> * Bug fixes:
>   * Bugfix for `UploadedFile.new` unintended API breakage.
>     (Per Lundberg [tonsky#210](https://github-redirect.dependabot.com/rack-test/rack-test/issues/210))
> 
> ## 0.8.0 / 2017-11-20
> 
> * Known Issue
>   * In `UploadedFile.new`, when passing e.g. a `Pathname` object,
>     errors can be raised (eg. `ArgumentError: Missing original_filename
>     for IO`, or `NoMethodError: undefined method 'size'`) See [tonsky#207](https://github-redirect.dependabot.com/rack-test/rack-test/issues/207), [tonsky#209](https://github-redirect.dependabot.com/rack-test/rack-test/issues/209).
></table> ... (truncated)
</details>
<details>
<summary>Commits</summary>

- See full diff in [compare view](https://github.com/rack-test/rack-test/commits/v1.1.0)
</details>
<br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

Co-authored-by: dependabot[bot] <support@dependabot.com>
Losangelosgenetics pushed a commit to Losangelosgenetics/FiraCode that referenced this issue Mar 12, 2020
@dependabot-support
Merge tonsky#209
3477b7d 
209: Update rubocop requirement from = 0.61.0 to = 0.61.1 r=olleolleolle a=dependabot[bot]

Updates the requirements on [rubocop](https://github.com/rubocop-hq/rubocop) to permit the latest version.
<details>
<summary>Changelog</summary>

*Sourced from [rubocop's changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md).*

> ## 0.61.1 (2018-12-06)
> 
> ### Bug fixes
> 
> * [#6550](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6550): Prevent Layout/RescueEnsureAlignment cop from breaking on assigned begin-end. ([[**drenmi**](https://github.com/drenmi)][])
> 
> ## 0.61.0 (2018-12-05)
> 
> ### New features
> 
> * [#6457](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6457): Support inner slash correction on `Style/RegexpLiteral`. ([[**r7kamura**](https://github.com/r7kamura)][])
> * [#6475](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6475): Support brace correction on `Style/Lambda`. ([[**r7kamura**](https://github.com/r7kamura)][])
> * [#6469](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6469): Enforce no parentheses style in the `Style/MethodCallWithArgsParentheses` cop. ([[**gsamokovarov**](https://github.com/gsamokovarov)][])
> * New cop `Performance/OpenStruct` checks for `OpenStruct.new` calls. ([[**xlts**](https://github.com/xlts)][])
> 
> ### Bug fixes
> 
> * [#6433](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6433): Fix Ruby 2.5 `Layout/RescueEnsureAlignment` error on assigned blocks. ([[**gmcgibbon**](https://github.com/gmcgibbon)][])
> * [#6405](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6405): Fix a false positive for `Lint/UselessAssignment` when using a variable in a module name. ([[**itsWill**](https://github.com/itsWill)][])
> * [#5934](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/5934): Handle the combination of `--auto-gen-config` and `--config FILE` correctly. ([[**jonas054**](https://github.com/jonas054)][])
> * [#5970](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/5970): Make running `--auto-gen-config` in a subdirectory work. ([[**jonas054**](https://github.com/jonas054)][])
> * [#6412](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6412): Fix an `unknown keywords` error when using `Psych.safe_load` with Ruby 2.6.0-preview2. ([[**koic**](https://github.com/koic)][])
> * [#6436](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6436): Fix exit status code to be 130 when rubocop is interrupted. ([[**deivid-rodriguez**](https://github.com/deivid-rodriguez)][])
> * [#6443](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6443): Fix an incorrect autocorrect for `Style/BracesAroundHashParameters` when the opening brace is before the first hash element at same line. ([[**koic**](https://github.com/koic)][])
> * [#6445](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6445): Treat `yield` and `super` like regular method calls in `Style/AlignHash`. ([[**mvz**](https://github.com/mvz)][])
> * [#3301](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/3301): Don't suggest or make semantic changes to the code in `Style/InfiniteLoop`. ([[**jonas054**](https://github.com/jonas054)][])
> * [#3586](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/3586): Handle single argument spanning multiple lines in `Style/TrailingCommaInArguments`. ([[**jonas054**](https://github.com/jonas054)][])
> * [#6478](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6478): Fix EmacsComment#encoding to match the `coding` variable. ([[**akihiro17**](https://github.com/akihiro17)][])
> * Don't show "unrecognized parameter" warning for `inherit_mode` parameter to individual cop configurations. ([[**maxh**](https://github.com/maxh)][])
> * [#6449](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6449): Fix a false negative for `Layout/IndentationWidth` when setting `EnforcedStyle: rails` of `Layout/IndentationConsistency` and method definition indented to access modifier in a singleton class. ([[**koic**](https://github.com/koic)][])
> * [#6482](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6482): Fix a false positive for `Lint/FormatParameterMismatch` when using (digit)$ flag. ([[**koic**](https://github.com/koic)][])
> * [#6489](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6489): Fix an error for `Style/UnneededCondition` when `if` condition and `then` branch are the same and it has no `else` branch. ([[**koic**](https://github.com/koic)][])
> * Fix NoMethodError for `Style/FrozenStringLiteral` when a file contains only a shebang. ([[**takaram**](https://github.com/takaram)][])
> * [#6511](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6511): Fix an incorrect auto-correct for `Style/EmptyCaseCondition` when used as an argument of a method. ([[**koic**](https://github.com/koic)][])
> * [#6509](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6509): Fix an incorrect auto-correct for `Style/RaiseArgs` when an exception object is assigned to a local variable. ([[**koic**](https://github.com/koic)][])
> * [#6534](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6534): Fix a false positive for `Lint/UselessAccessModifier` when using `private_class_method`. ([[**dduugg**](https://github.com/dduugg)][])
> * [#6545](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6545): Fix a regression where `Performance/RedundantMerge` raises an error on a sole double splat argument passed to `merge!`. ([[**mmedal**](https://github.com/mmedal)][])
> * [#6360](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6360): Detect bad indentation in `if` nodes even if the first branch is empty. ([[**bquorning**](https://github.com/bquorning)][])
> 
> ### Changes
> 
> * [#6492](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6492): Auto-correct chunks of comment lines in `Layout/CommentIndentation` to avoid unnecessary iterations for `rubocop -a`. ([[**jonas054**](https://github.com/jonas054)][])
> 
> ## 0.60.0 (2018-10-26)
> 
> ### New features
> 
> * [#5980](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/5980): Add `--safe` and `--safe-auto-correct` options. ([[**Darhazer**](https://github.com/Darhazer)][])
> * [#4156](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/4156): Add command line option `--auto-gen-only-exclude`. ([[**Ana06**](https://github.com/Ana06)][], [[**jonas054**](https://github.com/jonas054)][])
> * [#6386](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6386): Add `VersionAdded` meta data to config/default.yml when running `rake new_cop`. ([[**koic**](https://github.com/koic)][])
></table> ... (truncated)
</details>
<details>
<summary>Commits</summary>

- See full diff in [compare view](https://github.com/rubocop-hq/rubocop/commits/v0.61.1)
</details>
<br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

Co-authored-by: dependabot[bot] <support@dependabot.com>
@derekschinke
Copy link

derekschinke commented Jun 8, 2020 •
edited
Loading

Yeah, and there's already a code point for "🙲" instead of "&". Not sure why Fira Mono decided to go with the older version that can be mixed up with other characters.

@wopian
Copy link
Contributor

wopian commented Jun 9, 2020 •
edited
Loading

As a counter argument I'd say the modern sans ampersand looks even closer to the number 8 than the traditional ligature used by Mono does.

@RubenVerg
Copy link

RubenVerg commented Jun 9, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@broady @tonsky @pforhan @MadcapJake @wopian @aaaxx @derekschinke @RubenVerg