-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove fi/fl #902
Comments
+1. I recently got 2.0 (from 1.2) for a few of the nice new stylistic sets but was surprised the new |
I do think that Fira Code is beautiful too and would happily revisit this font, but the "fused letters" in a monospace font situation is too jarring to look at. Thanks a lot for opening this issue, @tonsky! All would be well if |
Another +1 here. I'm sure I'm not the only programmer using Fira Code who is annoyed by my editor constantly shifting text around when ligatures are updated every time I type |
hmm this shouldn’t happen. Even in ligatures, letters have exactly the same dimensions and position |
There's no logical reason that these characters should be fused. Gonna keep shopping around for other fonts. +1 for reverting. |
@tonsky This is still an issue for me in v2, is there a fix planned for this? |
I'm jumping ship to JetBrains Mono, which supports sensible ligatures but didn't go overboard with them. |
Forget it, I was using jetbrains
|
I've created a patched |
* Only warn once if defaults are not explicitly set * Setup defaults before spec too
Currency: from USD to nil Rounding: from ROUND_HALF_EVEN to ROUND_HALF_UP The warnings were added in tonsky#882 and tonsky#883 and refined in tonsky#902.
I agree. They look like one letter, which is confusing. |
Is there any reason against making this a setting? |
@tweakimp the amount of stylistic sets is limited to 20. So I have to choose carefully what most important 20 settings are. If I could, I would make everything a setting, of course. |
Thank you for your answer. How likely is this going to be optional? :) |
I’ll tell when I set down planning v3. I’ll either remove it or move it to a stylistic set |
aren't there two types of stylistic sets with 20 each? |
(and 21 anyway, I guess. ss00-ss20) |
Thanks so much for listening to the community feedback and removing these ligatures! |
The stable version of fira-code has these [weird][1] and [unpopular][2] ligatures for "fl" and "Fl". They are jarring, especially now that I'm rendering the word "flake" a lot. Fortunately, they've been reverted upstream. Bumping fira-code to unstable until the fix lands back on stable. [1]: tonsky/FiraCode#795 [2]: tonsky/FiraCode#902
@tonsky Hi Nikita. Have you seen the discussion here? Many people (including me) strongly dislike these ligatures. They look jarring in a monospace font (everything is spaced out, but then suddenly f and l are fused!?). And worst of all,
Tl
with the new ligatures looks likeπ
(pi). Wtf. Hehe. Please make these ligatures optional viass
setting... :-( The first feeling after installing the font today was "wow this font is beautiful, but... ewwww that ligature... can I turn it off somehow?"... Sad that I can't. :-( I'd much prefer the original in the OP's post above. :-SEdit: Ehm... my love for Fira Code was short lived (about 15 minutes). The "Fl / Tl" was so painful to look at that I started looking for other fonts. Found IBM Plex Mono at https://www.ibm.com/plex/ (https://github.com/IBM/plex/releases) which was designed by IBM for their programmers, to be looked at day in and day out. They used pixel-precise angles to ensure sharp rendering. It is incredibly crisp, extremely easy to read, and expertly designed. The italics are a work of art (which my editor uses for comments). There are no ligatures for stuff like
!=
, but the font puts those characters super close to each other (which looks great), so I don't miss ligatures. There is a modded version at IBM/plex#63 (comment) which adds ligatures if someone really wants that in the IBM Plex font... :-) Anyway, if Fira Code ever improves the "Pi"-like "Tl" situation, I may revisit this font too... but I'm off to IBM land now...Originally posted by @VideoPlayerCode in #795 (comment)
The text was updated successfully, but these errors were encountered: