Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: upgrade slf4j to 2.0.3 #247

Merged
merged 13 commits into from
Dec 4, 2022
Merged

feat!: upgrade slf4j to 2.0.3 #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
46435f4
Upgrade slf4f to 2.0.3
compscidr Oct 14, 2022
45950d6
implement clearDequeueByKey
compscidr Oct 14, 2022
40e33e7
Implemented the ServiceLoader method for slf4f 2.x.x provider detection
compscidr Oct 14, 2022
b521c7e
lint fixes
compscidr Oct 14, 2022
eada4af
fix infinite recursion
compscidr Oct 28, 2022
cbd5242
fixed some empty functions and some isEnabled functions
compscidr Oct 28, 2022
06a6ad0
revert dependency changes
compscidr Nov 17, 2022
7659ee0
fix a bunch of tests that I must have missed last time
compscidr Nov 17, 2022
14e6f3f
merge upstream/main
compscidr Nov 17, 2022
4a435f0
updated readme with 2.0.3 api to match
compscidr Nov 17, 2022
55a70b2
revert scope changes
compscidr Nov 17, 2022
1d49803
fix incorrect collections import
compscidr Nov 17, 2022
618fa33
Merge branch 'main' into slf4f-2.0.3
tony19 Dec 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,17 @@ Quick Start

```groovy
dependencies {
implementation 'org.slf4j:slf4j-api:' // slf4j 2.x not yet supported
implementation 'com.github.tony19:logback-android:2.0.2-SNAPSHOT'
implementation 'org.slf4j:slf4j-api:2.0.3'
implementation 'com.github.tony19:logback-android:2.0.1'
}
```

If using `logback-android` in unit tests, **either** [use Robolectric](https://github.com/tony19/logback-android/issues/151#issuecomment-466276739), **or** use this config instead:

```groovy
dependencies {
implementation 'org.slf4j:slf4j-api:' // slf4j 2.x not yet supported
implementation 'com.github.tony19:logback-android:2.0.2-SNAPSHOT'
implementation 'org.slf4j:slf4j-api:2.0.3'
implementation 'com.github.tony19:logback-android:2.0.1'
testImplementation 'ch.qos.logback:logback-classic:1.2.11'
}

Expand All @@ -41,8 +41,6 @@ Quick Start
}
```

**NOTE:** SLF4J 2.x is not [yet](https://github.com/tony19/logback-android/pull/247) supported.

3. Create `app/src/main/assets/logback.xml` containing:

```xml
Expand Down Expand Up @@ -95,8 +93,8 @@ _Gradle_ **release**

```groovy
dependencies {
implementation 'org.slf4j:slf4j-api:' // slf4j 2.x not yet supported
implementation 'com.github.tony19:logback-android:2.0.2-SNAPSHOT'
implementation 'org.slf4j:slf4j-api:2.0.3'
implementation 'com.github.tony19:logback-android:2.0.1'
}
```

Expand All @@ -108,7 +106,7 @@ repositories {
}

dependencies {
implementation 'org.slf4j:slf4j-api:' // slf4j 2.x not yet supported
implementation 'org.slf4j:slf4j-api:2.0.3'
implementation 'com.github.tony19:logback-android:2.0.2-SNAPSHOT'
}
```
Expand All @@ -121,5 +119,5 @@ Use these commands to create the AAR:
cd logback-android
scripts/makejar.sh

The file is output to: `./build/logback-android-2.0.0-debug.aar`
The file is output to: `./build/logback-android-2.0.1-debug.aar`

2 changes: 2 additions & 0 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ version=2.0.2-SNAPSHOT
VERSION_NAME=2.0.2-SNAPSHOT
VERSION_CODE=3020000

slf4jVersion=2.0.3

# Specifies the JVM arguments used for the daemon process.
# The setting is particularly useful for tweaking memory settings.
# Ensure important default jvmargs aren't overwritten. See https://github.com/gradle/gradle/issues/19750
Expand Down
2 changes: 1 addition & 1 deletion logback-android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ dependencies {
testImplementation 'com.icegreen:greenmail:1.6.11'
testImplementation 'dom4j:dom4j:1.6.1'
testImplementation 'org.easytesting:fest-assert:1.4'
testImplementation "org.slf4j:integration:${slf4jVersion}"
testImplementation "org.slf4j:integration:2.0.0-alpha1" // don't seem to have any stable 2.x releases yet: https://mvnrepository.com/artifact/org.slf4j/integration
testImplementation "org.slf4j:log4j-over-slf4j:${slf4jVersion}"
testImplementation "org.slf4j:slf4j-api:${slf4jVersion}:tests"
testImplementation "org.slf4j:slf4j-ext:${slf4jVersion}"
Expand Down
Loading