[Discover] Fix breakdownField in getDefaultAppState
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch_all promise is resolved when no results are found
davismcphee
commented
Nov 21, 2024
There was a problem hiding this comment.
@tonyghiani CI is passing in the draft PR against main, so these changes should be good to go now: elastic#200854.
src/plugins/discover/public/application/main/state_management/utils/build_state_subscribe.ts
Show resolved
Hide resolved
|
Thanks a lot Davis, I'll merge this into my PR and address any change left for this to work! |
tonyghiani
merged commit 0825111
into
tonyghiani:183498-breakown-by-log-level
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes support for
breakdownFieldingetDefaultAppStateto ensure it gets set when expected and does not trigger additional data fetching. It does this by splittinggetDefaultProfileStateinto two phases:getPreFetchStateandgetPostFetchState, which apply default state before and after data fetching respectively.There are also some related changes to make this work, mainly around Discover's (complicated) state management, and ES|QL mode special handling. I also had to change the way Unified Histogram receives the
breakdownFieldsince the current approach was causing a race condition (all the more reason to improve and refactor Unified Histogram).