Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge remote repo #1

Merged
merged 3 commits into from
Apr 28, 2019
Merged

merge remote repo #1

merged 3 commits into from
Apr 28, 2019

Commits on Apr 28, 2019

  1. lib: print to stdout/stderr directly instead of using console 

    This patch adds an internal function that prints to stdout or
stderr by directly writing to the known file descriptor, and
uses it internally in common cases to avoid the overhead
of the console implementation.

PR-URL: #27320
Reviewed-By: James M Snell <jasnell@gmail.com>
    @joyeecheung
    joyeecheung committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    2b24ffa View commit details
    Browse the repository at this point in the history

  2. benchmark: add benchmark for node -p 

    PR-URL: #27320
Reviewed-By: James M Snell <jasnell@gmail.com>
    @joyeecheung
    joyeecheung committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    c5817ab View commit details
    Browse the repository at this point in the history

  3. process: reduce the number of internal frames in async stack trace 

    Previously, we call the JS land `runNextTicks` implementation
immediately from JS land after evaluating the main module or the
input, so these synchronous JS call frames would show up in the stack
trace of the async errors, which can be confusing. This patch moves
those calls into C++ so that more of these internal scheduler
implementation details can be hidden and the users can see a cleaner
a cleaner async JS stack trace.

PR-URL: #27392
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    @joyeecheung
    joyeecheung committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    757f3f8 View commit details
    Browse the repository at this point in the history