Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore logical type conversion and just deliver already converted value if its type matches the target type #84

Merged
merged 2 commits into from
Jul 13, 2024

Conversation

zambrovski
Copy link
Contributor

@zambrovski zambrovski requested a review from jangalinski July 12, 2024 18:42
@zambrovski zambrovski self-assigned this Jul 12, 2024
@zambrovski zambrovski added the Type: bug Something isn't working label Jul 12, 2024
@zambrovski zambrovski added this to the 1.11.4.4 milestone Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 65.51724% with 10 lines in your changes missing coverage. Please review.

Project coverage is 69.70%. Comparing base (e4b54af) to head (e985274).

Files Patch % Lines
...in/kotlin/serializer/BytesLogicalTypeSerializer.kt 20.00% 2 Missing and 2 partials ⚠️
.../kotlin/serializer/BooleanLogicalTypeSerializer.kt 75.00% 0 Missing and 1 partial ⚠️
...n/kotlin/serializer/DoubleLogicalTypeSerializer.kt 75.00% 0 Missing and 1 partial ⚠️
...in/kotlin/serializer/FloatLogicalTypeSerializer.kt 75.00% 0 Missing and 1 partial ⚠️
...main/kotlin/serializer/IntLogicalTypeSerializer.kt 75.00% 0 Missing and 1 partial ⚠️
...ain/kotlin/serializer/LongLogicalTypeSerializer.kt 75.00% 0 Missing and 1 partial ⚠️
...n/kotlin/serializer/StringLogicalTypeSerializer.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #84      +/-   ##
=============================================
+ Coverage      63.10%   69.70%   +6.59%     
=============================================
  Files            108      108              
  Lines           1610     1624      +14     
  Branches         120      127       +7     
=============================================
+ Hits            1016     1132     +116     
+ Misses           514      402     -112     
- Partials          80       90      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zambrovski zambrovski merged commit fea2dfb into develop Jul 13, 2024
4 checks passed
@zambrovski zambrovski deleted the bugfix/83__double_logic_types branch July 13, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deserialization of Logical Types doesn't work correctly
2 participants