Add new analysis node for creating histogram of data #241
Conversation
…pical dispersive readout of cQED qubits.
|
@wpfff will have a look by monday/tuesday, is htat ok? |
|
Absolutely, thanks! |
astafan8
changed the title
There was a problem hiding this comment.
Looks good! I will try to run this locally within a few days in an attempt to confirm that nothing broke :)
it would be great to make the GUI tests executed by CI... and i don't mean "assert press of button foo results in bar" but really at least just make sure these get executed and don't crash accidentally ))
| :return: ``None`` | ||
| """ | ||
| self.clear() | ||
| allDims = self.entries + list(dims) |
There was a problem hiding this comment.
should this actually change self.entries and call addItem on elements of that? or is self.entries actually unused?
There was a problem hiding this comment.
self.entries contains currently only one element, None, to give the user the option to not select any item.
And that entry should be stored somewhere other than the actual item list, because it would be cleared when we set a new list of dimensions.
So there will in any case always at least be the None in the dropdown. It looks maybe a bit weird, but i wanted to have that information not in the function but rather in the constructor, and was thinking of cases where more than just the None could be useful to fall under that category.
Fair point -- i'll look into that. Do you have any experience with that? i never tried running tests with GUI elements. |
|
@astafan8 i've added a test for the new node (incl the ui, at least a basic one). |
There was a problem hiding this comment.
@wpfff thanks for the UI tests, they are a good start! going forward, i think, that these tests are very useful for verifying that the chain of signals and slots works as expected, not only the fact that the UI can render :)
|
Thanks @astafan8 -- great idea, I agree this would be useful. I started to look into pytest-qt more, I'll probably improve some things with it in the coming weeks. |
Added a new node that allows creating histograms of data.
Also promoted a few things (like axis selection widgets) to more general tools, and fixed a few bugs that i ran into while developing the new feature.