Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate UUID only once per DDH5Writer #371

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

yoshi74ls181
Copy link
Contributor

Currently, DDH5Writer.data_folder() returns a different path every time it is called because the UUID is re-generated each time.
With this bugfix, the UUID is generated only once when a DDH5Writer is instantiated.

Copy link
Collaborator

@marcosfrenkel marcosfrenkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yoshi74ls181
Copy link
Contributor Author

Thanks!

@marcosfrenkel marcosfrenkel merged commit 0835387 into toolsforexperiments:master Feb 20, 2023
@yoshi74ls181 yoshi74ls181 deleted the bugfix-uuid branch February 20, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants