Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Jimp to address minimist security vulnerability #4

Closed
wants to merge 2 commits into from
Closed

Upgrade Jimp to address minimist security vulnerability #4

wants to merge 2 commits into from

Conversation

tooolbox
Copy link
Owner

Clone of iwsfg#11

karlhorky and others added 2 commits March 19, 2020 10:21
Co-Authored-By: Corbin Crutchley <crutchcorn@gmail.com>
@tooolbox
Copy link
Owner Author

@karlhorky with the goal of being more proactive about merging PRs and publishing them, I added CI via GitHub actions, which required a package-lock.json file. Can you fix your branch so this is present and the checks pass?

Otherwise it doesn't seem that the Jimp releases have changed anything we care about so I think we should be good.

Thanks.

@karlhorky
Copy link

karlhorky commented Mar 29, 2020

Ah, I wasn't aware that your fork is the official repository now! Do you have contact with @iwasawafag? Maybe his repo can be transferred to you instead of maintaining a fork (or placed under an organization), to minimize future confusion...

Alternately, at the very least probably a very large "Deprecated" warning with a link to your fork should be at the top of the readme...


I have opened this new pull request instead, which has been also linked from the old one: #5

@tooolbox tooolbox closed this Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants