Float formatting #838
Closed
Float formatting #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… includes tests for floats < 0 which are also formatted incorrectly
…he fact, that rpyton Float formatting mode 'r' rounds as Ruby 1.9.3 does
|
Of there is a rubyspec for this, can you make sure it runs? (untagging it should work) |
|
s/Of/If |
|
Sure I'll have a look |
|
Turns out the Float#to_s specs include all the information I was manually assembling before -.-'. Thus my changes don't implement everything yet, so I'm closing the pull request for now and reopen it when I've also implemented the rest of the Float#to_s spec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to fix #779. Float#to_s should create the closest string representation of the float which itself creates the float again. The RPython float to string mode "r" allows this and only needed some polishing to match the formatting of Ruby 1.9.3