Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on room manager during create room method #542

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

arthur29
Copy link
Contributor

@arthur29 arthur29 commented Oct 6, 2022

Why

During the new room's creation in the RoomsManager there are a lot of errors like this one:

"msg":"failed to process event","service_name":"runtime_watcher","error":"failed to update room instance 
<<INSTANCE_NAME>>: failed to update game room status: failed to get game room: room <<INSTANCE_NAME>> 
not found in scheduler <<SCHEDULER_NAME>>"}

This error happens when the room starts before the creation process finishes and the proper game room was created in the room storage.

What

This PR proposes to change the sequence during the creation process to the room being created before the instance creation, so if the room starts to ping the game room will already be created in the storage and it could update the room status by the ping.

Copy link
Collaborator

@tobiasbu tobiasbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@arthur29 arthur29 merged commit ada676e into main Oct 6, 2022
@arthur29 arthur29 deleted the fix_error_on_room_manager_create_room_function branch October 6, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants