Fix error on room manager during create room method #542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
During the new room's creation in the
RoomsManager
there are a lot of errors like this one:This error happens when the room starts before the creation process finishes and the proper game room was created in the room storage.
What
This PR proposes to change the sequence during the creation process to the room being created before the instance creation, so if the room starts to ping the game room will already be created in the storage and it could update the room status by the ping.