Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly handling timeout when revoking ETCD lease #419

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

reinaldooli
Copy link
Collaborator

This is a cherrypick from the changes made here.
Since pitaya v3 still using ETCD, these changes needs to be propagated.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10457228137

Details

  • 0 of 12 (0.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 59.164%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cluster/etcd_service_discovery.go 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/modules/binary.go 4 69.57%
Totals Coverage Status
Change from base Build 10368957457: -0.04%
Covered Lines: 4900
Relevant Lines: 8282

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants