Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ZVM #777

Merged
merged 1 commit into from
Jul 22, 2024
Merged

feat: support ZVM #777

merged 1 commit into from
Jul 22, 2024

Conversation

SteveLauC
Copy link
Member

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed

  • Optional: The --dry-run option works with this step

  • Optional: The --yes option works with this step if it is supported by
    the underlying command

    cc @tristan-nsg, does zvm have a --yes option?

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

@SteveLauC SteveLauC linked an issue Apr 21, 2024 that may be closed by this pull request
@SteveLauC
Copy link
Member Author

Gentle ping on @tristan-nsg again, could you please take a look at this?

@topgrade-rs topgrade-rs deleted a comment from codecov bot Jul 20, 2024
Copy link

@tristan-nsg tristan-nsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for me!

@SteveLauC SteveLauC merged commit b8da171 into topgrade-rs:main Jul 22, 2024
11 checks passed
@SteveLauC SteveLauC deleted the feat/zvm branch July 22, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could TopGrade Please Support ZVM?
2 participants