Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for whether conda config contains auto_activate_base #905

Merged

Conversation

Pipboyguy
Copy link
Contributor

@Pipboyguy Pipboyguy commented Sep 14, 2024

What does this PR do

Removes redundant auto_activate_base check.

mamba update --all -n base should work whether the base is activated or not.

Standards checklist

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • I have tested the code myself

Fixes #731

Signed-off-by: Marcel Coetzee <marcel@mooncoon.com>
@SteveLauC
Copy link
Member

SteveLauC commented Sep 15, 2024

Hi, I am not familiar with this tool, let me try seeking some help from a Conda core member😣


Hi @marcelotrevisani, sorry for the ping, would you mind taking a look at this PR, -n base was added in #495, is that auto_activate_base check still necessary after adding -n base?

@marcelotrevisani
Copy link
Contributor

hey, yes, auto_activate_base is not necessary with -n base :)
I hope that helps

@SteveLauC
Copy link
Member

Thnaks for the help! Merging

@SteveLauC SteveLauC merged commit ad41948 into topgrade-rs:main Sep 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mamba update fails with Command failed: mamba config --show auto_activate_base
3 participants