Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: don't call execute("bin_name_str") #916

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

SteveLauC
Copy link
Member

@SteveLauC SteveLauC commented Sep 26, 2024

What does this PR do

We should never directly invoke ctx.run_type().execute("binary_name_str") as this can lead to issues on Windows due to
the weird behavior of binary lookup in Rust std, always let require() do the binary lookup job. For example, here is an issue that we have encountered: #725

Standards checklist

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

@SteveLauC SteveLauC merged commit a885742 into topgrade-rs:main Sep 26, 2024
11 checks passed
@SteveLauC SteveLauC deleted the docs/contributing branch September 26, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant