Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(poetry): skip if not installed with official script #989

Merged
merged 3 commits into from
Dec 7, 2024

Conversation

AThePeanut4
Copy link
Contributor

@AThePeanut4 AThePeanut4 commented Nov 24, 2024

What does this PR do

This skips the poetry self update step if poetry is not installed using the official installer script, preventing externally-managed-environment errors if it was installed through e.g. a package manager.

I've also added a config option (python.poetry_force_self_update) that bypasses the check to always run poetry self update - this is useful for manual installations.

Standards checklist

  • The PR title is descriptive
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself - tested on both Linux and Windows
  • If this PR introduces new user-facing messages they are translated

Fixes #979

Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SteveLauC
Copy link
Member

I took the liberty to document the new configuration entry in more details:)

@SteveLauC SteveLauC merged commit 305a5fb into topgrade-rs:main Dec 7, 2024
12 checks passed
@AThePeanut4 AThePeanut4 deleted the poetry-skip-self-update branch December 7, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry self update fails with externally-managed-environment errors
2 participants