Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose lavasearch under the api scope #126

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

freyacodes
Copy link
Contributor

I am encountering this compiler error with LavaSrc as a dependency:

e: Supertypes of the following classes cannot be resolved. Please make sure you have the required dependencies in the classpath:
    class com.github.topi314.lavasrc.deezer.DeezerAudioSourceManager, unresolved supertypes: com.github.topi314.lavasearch.AudioSearchSourceManager
Adding -Xextended-compiler-checks argument might provide additional information.

e: file:///home/freya/git/tenshi/tenshi/src/main/java/fredboat/config/AudioPlayerManagerConfiguration.kt:296:74 Cannot access 'com.github.topi314.lavasearch.AudioSearchSourceManager' which is a supertype of 'com.github.topi314.lavasrc.deezer.DeezerAudioSourceManager'. Check your module classpath for missing or conflicting dependencies

The problem appears to be that AudioSearchSourceManager is unavailable as a transitive dependency because of the implementation scope. I have not tested this PR, however putting lavasearch into scope in my project fixes the compile error.

@topi314 topi314 merged commit 5adedc3 into topi314:master Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants