Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yandex Music Updates #197

Merged
merged 5 commits into from
May 16, 2024
Merged

Yandex Music Updates #197

merged 5 commits into from
May 16, 2024

Conversation

Krispeckt
Copy link
Contributor

@Krispeckt Krispeckt commented May 15, 2024 •
edited by topi314
Loading

  • The recommendation logic for the track is implemented
  • Added query argument to get full tracks without pain and checks
  • Fixed parseCoverUri
  • Wrote load limits for playlists, artists, albums

@Krispeckt
- Wrote coverUri parser, forgot that there are itemsUri (For example,…
98fa3fd 
… several avatars, then there will be no uri).

- Also wrote load limits (to not load playlists with more than 2000 tracks if someone doesn't need it).
- Now you can get similar tracks using ymrec:identifier query (only for one track).
- Also added support for music.yandex.by and music.yandex.kz domains.
- Having analyzed it, I can see that deviant tracks don't have key "available" (which all normal tracks have), so I moved the logic to parseTracks to make it safe.
topi314
topi314 requested changes May 15, 2024
View reviewed changes
Copy link
Owner

@topi314 topi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am gonna assume you tested this

can you rebase these change onto master and add default config values like I did in my last commit?

also when you pass in a yandex .kz/.by should those links returned have that domain ending?

you should also add ymrec: to the readme

@topi314 topi314 added enhancement New feature or request bugfix Something is hopefully working now labels May 15, 2024
@Krispeckt
Copy link
Contributor Author

Krispeckt commented May 15, 2024 •
edited
Loading

I am gonna assume you tested this

can you rebase these change onto master and add default config values like I did in my last commit?

also when you pass in a yandex .kz/.by should those links returned have that domain ending?

you should also add ymrec: to the readme

Yes, it's all been tested. Personally I had no problems, I'm not sure about deviant tracks, but if you refer to the json response from AgutinVBoy, such tracks really do not have the "available" key. About domains, they do exist #164.

I will make a commit in the near future.

@topi314
Copy link
Owner

topi314 commented May 15, 2024

Yeah I saw you added those other domains to the regex which is fine

But all returned track links default to the standard domain atm, and I was asking if you want/should keep those domains when loading a track/playlist

@Krispeckt
Added ymrec to readme and added config default values for yandex musi…
f4c1dd5 
…c. Now the ending of the domain name depends on the link given to it, "com" is used in searches
@Krispeckt
Copy link
Contributor Author

Yeah I saw you added those other domains to the regex which is fine

But all returned track links default to the standard domain atm, and I was asking if you want/should keep those domains when loading a track/playlist

I didn't understand the question from the beginning, sorry. Is that what you meant?

topi314
topi314 requested changes May 16, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
main/src/main/java/com/github/topi314/lavasrc/yandexmusic/YandexMusicSourceManager.java Outdated Show resolved Hide resolved
@Krispeckt Krispeckt changed the title - Wrote coverUri parser, forgot that there are itemsUri (For example,… The recommendation logic for the track is implemented. Added query argument to get full tracks without pain and checks. Fixed parseCoverUri. Wrote load limits for playlists, artists, albums. May 16, 2024
@topi314 topi314 changed the title The recommendation logic for the track is implemented. Added query argument to get full tracks without pain and checks. Fixed parseCoverUri. Wrote load limits for playlists, artists, albums. Yndex Music Updates May 16, 2024
@Krispeckt
Copy link
Contributor Author

:<

@topi314 topi314 changed the title Yndex Music Updates Yandex Music Updates May 16, 2024
@topi314
Copy link
Owner

topi314 commented May 16, 2024

that was a terrible pr name lol

@Krispeckt
Copy link
Contributor Author

okay((

@topi314 topi314 merged commit 20403f0 into topi314:master May 16, 2024
@topi314
Copy link
Owner

topi314 commented May 16, 2024

anyway thanks for all the stuff

This was referenced May 16, 2024
Closed
Closed
@Krispeckt
Copy link
Contributor Author

anyway thanks for all the stuff

Lul, it's in my best interest too, since I use the plugin too

@topi314 topi314 mentioned this pull request May 16, 2024
Closed
@topi314
Copy link
Owner

topi314 commented May 16, 2024

not even allowed to thank people anymore :(

@Krispeckt Krispeckt deleted the load-limits branch May 24, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topi314 topi314 topi314 approved these changes

Assignees
No one assigned
Labels
bugfix Something is hopefully working now enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Krispeckt @topi314