-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various bugs with the merge tree states #966
Comments
Interestingly, these bugs do not seem to affect the PD-PGA state (topology-tool-kit/ttk-data#148). |
Also interestingly, the states work fine on my computer with the current branches of ttk and ttk-data (except for the color bug in branches). However the libraries version differ. System |
Same screenshots after updating numpy to 1.25.2. |
I confirm that the issue with the missing geometry can no longer be reproduced (for mergeTreeClustering, mergeTreeTemporalReduction, mergeTreeFeatureTracking, mergeTreePGA). |
I confirm the issue is completely solved with PR #974 (tested on my home workstation). |
Describe the bug
Most of the merge tree states are affected by several bugs.
To Reproduce
In the ttk-data repository:
paraview states/mergeTreeClustering.pvsm
paraview states/mergeTreeFeatureTracking.pvsm
paraview states/mergeTreePGA.pvsm
paraview states/mergeTreeTemporalReduction.pvsm
Expected behavior
The planar layout of the trees includes spheres and tubes. The dimension reductions display properly, see the reference screenshots:
https://topology-tool-kit.github.io/img/gallery/mergeTreeClustering.jpg
https://topology-tool-kit.github.io/img/gallery/mergeTreeFeatureTracking.jpg
https://topology-tool-kit.github.io/img/gallery/mergeTreePGA.jpg
https://topology-tool-kit.github.io/img/gallery/mergeTreeTemporalReduction.jpg
Screenshots
Please find below screenshots which exemplify the issues on my system
Merge tree clustering
In the planar view of the trees:
Merge tree feature tracking
In the planar view of the trees:
Merge tree PGA
The 2D views are empty :(
(TTKMergeBlockTables2 is empty but ExtractSurface1 does contain the surface???!!!)
Merge tree temporal reduction
In the planar view of the trees:
System (please complete the following information):
Additional context
This bug is for @MatPont (after he's done with his manuscript write-up).
The color bug seems to be a consequence of one of Mathieu's latest PRs regarding the insertion of additional information along the arcs of the merge trees. Maybe it can be fixed in the state itself, but more likely with code adjustments.
The sphere, tubes and surface bugs are a little more surprising (these states are not tested by the CI because of their memory footprint). These should be fixable by state adjustments. Otherwise, one would need to roll back the history of commit to the last version of TTK for which these states were OK and search for the fault commits.
The text was updated successfully, but these errors were encountered: