Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various bugs with the merge tree states #966

Closed
julien-tierny opened this issue Aug 31, 2023 · 5 comments · Fixed by #974
Closed

Various bugs with the merge tree states #966

julien-tierny opened this issue Aug 31, 2023 · 5 comments · Fixed by #974

Comments

@julien-tierny
Copy link
Collaborator

Describe the bug
Most of the merge tree states are affected by several bugs.

To Reproduce
In the ttk-data repository:
paraview states/mergeTreeClustering.pvsm
paraview states/mergeTreeFeatureTracking.pvsm
paraview states/mergeTreePGA.pvsm
paraview states/mergeTreeTemporalReduction.pvsm

Expected behavior
The planar layout of the trees includes spheres and tubes. The dimension reductions display properly, see the reference screenshots:
https://topology-tool-kit.github.io/img/gallery/mergeTreeClustering.jpg
https://topology-tool-kit.github.io/img/gallery/mergeTreeFeatureTracking.jpg
https://topology-tool-kit.github.io/img/gallery/mergeTreePGA.jpg
https://topology-tool-kit.github.io/img/gallery/mergeTreeTemporalReduction.jpg

Screenshots
Please find below screenshots which exemplify the issues on my system

Merge tree clustering
In the planar view of the trees:

  • Spheres are missing for the nodes
  • The tubes are not colored properly
    Screenshot_20230831_094350

Merge tree feature tracking
In the planar view of the trees:

  • Spheres are missing for the nodes
  • The tubes are not colored properly
    Screenshot_20230831_095908

Merge tree PGA
The 2D views are empty :(
(TTKMergeBlockTables2 is empty but ExtractSurface1 does contain the surface???!!!)
Screenshot_20230831_101530

Merge tree temporal reduction
In the planar view of the trees:

  • Spheres are missing for the nodes
  • The tubes are not colored properly
    Screenshot_20230831_100824

System (please complete the following information):

  • TTK dev
  • ParaView 5.11
  • numpy 1.25.2
  • scikit-learn 1.1.2

Additional context
This bug is for @MatPont (after he's done with his manuscript write-up).

The color bug seems to be a consequence of one of Mathieu's latest PRs regarding the insertion of additional information along the arcs of the merge trees. Maybe it can be fixed in the state itself, but more likely with code adjustments.

The sphere, tubes and surface bugs are a little more surprising (these states are not tested by the CI because of their memory footprint). These should be fixable by state adjustments. Otherwise, one would need to roll back the history of commit to the last version of TTK for which these states were OK and search for the fault commits.

@julien-tierny
Copy link
Collaborator Author

Interestingly, these bugs do not seem to affect the PD-PGA state (topology-tool-kit/ttk-data#148).
Maybe the latest re-factoring could be the issue? (#944)

@MatPont
Copy link
Contributor

MatPont commented Aug 31, 2023

Also interestingly, the states work fine on my computer with the current branches of ttk and ttk-data (except for the color bug in branches). However the libraries version differ.
Perhaps we would need to test these states on other computers (or different libraries version).

System
TTK dev
ParaView 5.10
Numpy 1.21.5
scikit-learn 0.23.2 (I'm not sure if we have checked the same thing here since it seems to be a big difference, I printed sklearn.__version__ after importing sklearn in python).

Screenshot from 2023-08-31 11-05-53
Screenshot from 2023-08-31 11-06-31
Screenshot from 2023-08-31 11-11-09
Screenshot from 2023-08-31 11-05-50

@MatPont
Copy link
Contributor

MatPont commented Aug 31, 2023

Same screenshots after updating numpy to 1.25.2.
(It was just a quick attempt to reproduce the bug but I will investigate that, like you said, after the manuscript)

@julien-tierny
Copy link
Collaborator Author

I confirm that the issue with the missing geometry can no longer be reproduced (for mergeTreeClustering, mergeTreeTemporalReduction, mergeTreeFeatureTracking, mergeTreePGA).
It looks like this was a numpy related-issue.

@julien-tierny
Copy link
Collaborator Author

I confirm the issue is completely solved with PR #974 (tested on my home workstation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants