Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PlanarLayout] fix persistence array #974

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

MatPont
Copy link
Contributor

@MatPont MatPont commented Oct 2, 2023

This PR fixes #966 by fixing the code introduced in #944.

  • Problem: The PR [MT-PGA] refactor and convert to diagram feature #944 added arrays encoding persistence for nodes and arcs in the vtk output (it was related to the feature to manage persistence diagrams).
    However, persistence arrays already existed in the code, resulting in an overwrite (only one vtk array with the same name can exists).
    The persistence arrays that remained at the end of the algorithm worked only for persistence diagrams and not for merge trees.
  • Solution: the duplicated arrays encoding persistence are removed, and the already existing arrays are generalized to take into account the fact that persistence diagrams can be used.

@julien-tierny
Copy link
Collaborator

wonderful, thanks!

@julien-tierny julien-tierny merged commit 798fb82 into topology-tool-kit:dev Oct 5, 2023
45 checks passed
@MatPont MatPont deleted the mt_layout_pers_fix branch October 6, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various bugs with the merge tree states
2 participants