Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing includes for PV master #1004

Merged

Conversation

CharlesGueunet
Copy link
Contributor

Dear Julien,

On PV Master, the VTK_VERSION_NUMBER now needs an explicit include of vtkVersionMacro.h. This MR allows TTK to compile on PV master once again :)

Best,
Charles

@julien-tierny
Copy link
Collaborator

thanks a lot @CharlesGueunet!
in principle, I have the impression that vtkVersionMacro.h should also be inserted for other occurrences of VTK_VERSION_NUMBER (core/vtk/ttkExtract/ttkExtract.cpp, core/vtk/ttkAlgorithm/ttkTriangulationFactory.cpp, ttkPersistenceDiagram/ttkPersistenceDiagramUtils.cpp). could you add those in as well real quick?

@CharlesGueunet
Copy link
Contributor Author

thanks a lot @CharlesGueunet! in principle, I have the impression that vtkVersionMacro.h should also be inserted for other occurrences of VTK_VERSION_NUMBER (core/vtk/ttkExtract/ttkExtract.cpp, core/vtk/ttkAlgorithm/ttkTriangulationFactory.cpp, ttkPersistenceDiagram/ttkPersistenceDiagramUtils.cpp). could you add those in as well real quick?

Done !

@julien-tierny
Copy link
Collaborator

alright, thanks a lot!

@julien-tierny julien-tierny merged commit 0b76f06 into topology-tool-kit:dev Jan 17, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants