Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ci] Partial updates for recent macOS image upgrades #1080

Merged
merged 10 commits into from
Dec 13, 2024

Conversation

julien-tierny
Copy link
Collaborator

This PR updates the test workflow given the recent upgrades of the Github macOS image upgrades.

Notes:

  • The package workflow is only partially updated (see below)
  • The python binaries are simply segfaulting under the new macOS images (the corresponding tests are currently disabled). This is problematic. I will try next to go back to the native python provided with the image (instead of brew's version, this will be test soon). @pierre-guillou do you have any idea of why python is segfaulting right of the bat under macos?

@julien-tierny julien-tierny merged commit 1e9a425 into topology-tool-kit:dev Dec 13, 2024
49 checks passed
@pierre-guillou
Copy link
Contributor

Hello,
From what I saw, python and pvpython crash when importing vtk.
This seems related to brew's Python.
Switching back to setup-python for building Paraview and TTK seems to work. c.f. https://github.com/pierre-guillou/paraview-ttk/actions/runs/12320285578 and https://github.com/pierre-guillou/ttk/actions/runs/12341335198.
My patches consist in 4 commits available at https://github.com/pierre-guillou/ttk/tree/ci.

@julien-tierny
Copy link
Collaborator Author

Thanks a lot for your great feedback @pierre-guillou !!!
I updated ttk-paraview and ttk workflows accordingly and I confirm that now python and pvpython both run fine (without segfaults anymore).

However, I now run into other issues further down the test workflow. In particular, it seems that the run.py script uses Python features which do not seem available in Github's default python:3.12.
Here's the log, look at the Run ttk-data Python scripts step
https://github.com/julien-tierny/ttk/actions/runs/12415698333/job/34662648130

Do you have any clue of what's going on precisely and/or how to fix this?
Thanks a lot for your great feedback!

@pierre-guillou
Copy link
Contributor

Yes, I stumbled on the same error last week(-end).
Apparently, the pvpython executable is expecting some vktpython in /Library/Frameworks/Python.framework/Versions/3.12/vtkpython.
I just added a symlink from pvpython and it seems to work.

I rebased my branch https://github.com/pierre-guillou/ttk/tree/ci on top of yours. Now it contains only 2 small commits.

Note that when enabling the .pvsm CI, there is a lot of noisy omp_set_nested routine deprecated, please use omp_set_max_active_levels instead. in TTK filters using OpenMP tasks.

Also, you might want to skip persistentGenerators_householdAnalysis.pvsm since it took 1h30 to complete (the Rips complex takes a long time to render).

Pierre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants