Merge pull request #620 from toptal/avoid-index-updates-with-empty-re…

…flections Avoid Elasticsearch index updates when passing empty reflections
toptal · Dec 22, 2017 · e2a62dd · e2a62dd
2 parents 1a13f75 + 2eeff14
commit e2a62dd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/lib/chewy/type/import.rb b/lib/chewy/type/import.rb
@@ -126,6 +126,7 @@ def compose(object, crutches = nil, fields: [])
       private
 
         def import_routine(*args)
+          return if args.first.blank? && !args.first.nil?
           routine = Routine.new(self, args.extract_options!)
           routine.create_indexes!
 

diff --git a/spec/chewy/type/import_spec.rb b/spec/chewy/type/import_spec.rb
@@ -40,6 +40,12 @@ def subscribe_notification
       CitiesIndex::City.import(dummy_city)
     end
 
+    specify 'lazy without objects' do
+      expect(CitiesIndex).not_to receive(:exists?)
+      expect(CitiesIndex).not_to receive(:create!)
+      CitiesIndex::City.import([])
+    end
+
     context 'skip' do
       before do
         # To avoid flaky issues when previous specs were run