Refactor/extract method on prefix #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it ready to be merged? |
|
Absolutely. |
|
I mean, there will be a second PR incoming with an additional change but that one needs a bit more discussion than this does so I figured I'd do it separately. Cheers. |
pyromaniac
added a commit
that referenced
this pull request
Jan 23, 2016
…prefix Refactor/extract method on prefix
|
Perfect, thanks! |
|
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an open issue #225 where a monkey patch is suggested in order to get Chewy working nicely in multitenant environments.
This change will make that monkey patch much smaller to implement (you would only need to override the
default_prefixmethod) as well as generally reducing repetition in the code (less references to the same configuration option).It also paves the way for more advanced prefix-calculating functionality in the future.