Allow app/chewy location to be changed via yml config #414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again!
In our rails application directory we have the following folders:
While integrating the Chewy gem, I added the
app/chewy
folder to the application. There were a few complaints that 'chewy' didn't match the convention applied in theapp/
directory, and so I was able to change it toapp/indices
with a little creative monkey patching.This patch allows the directory to be set with a new config option called
index_definition_path
.I tried to find every place the path was hard coded and replace with
Chewy.configuration[:index_definition_path]
.Additionally, the default setting is
app/chewy
so current deployments shouldn't need to change anything.Thoughts?
Thanks!