Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rails version in CI matrix #733

Merged
merged 2 commits into from
Jan 27, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 19 additions & 33 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,11 @@ workflows:
build:
jobs:
- rubocop
- rspec-ruby-25-activerecord60
- rspec-ruby-25-activerecord52
- rspec-ruby-25-mongoid
- rspec-ruby-26-activerecord61
- rspec-ruby-26-activerecord60
- rspec-ruby-26-activerecord52
- rspec-ruby-26-mongoid
- rspec-ruby-27-activerecord61
- rspec-ruby-27-activerecord60
- rspec-ruby-27-activerecord52
- rspec-ruby-27-mongoid
Expand Down Expand Up @@ -105,9 +104,9 @@ jobs:
command: |
bundle exec rubocop --format simple

rspec-ruby-25-activerecord52:
rspec-ruby-26-activerecord52:
docker:
- image: circleci/ruby:2.5
- image: circleci/ruby:2.6
- image: docker.elastic.co/elasticsearch/elasticsearch:5.6.7
environment:
<<: *es56-env
Expand All @@ -117,9 +116,9 @@ jobs:
steps:
- rspec-test

rspec-ruby-25-activerecord60:
rspec-ruby-26-activerecord60:
docker:
- image: circleci/ruby:2.5
- image: circleci/ruby:2.6
- image: docker.elastic.co/elasticsearch/elasticsearch:5.6.7
environment:
<<: *es56-env
Expand All @@ -129,77 +128,64 @@ jobs:
steps:
- rspec-test

rspec-ruby-25-mongoid:
docker:
- image: circleci/ruby:2.5
- image: circleci/mongo:4.2.5
- image: docker.elastic.co/elasticsearch/elasticsearch:5.6.7
environment:
<<: *es56-env
working_directory: ~/repo
environment:
GEMFILE: gemfiles/rails.5.1.mongoid.6.3.gemfile
steps:
- rspec-test

rspec-ruby-26-activerecord52:
rspec-ruby-26-activerecord61:
docker:
- image: circleci/ruby:2.6
- image: docker.elastic.co/elasticsearch/elasticsearch:5.6.7
environment:
<<: *es56-env
working_directory: ~/repo
environment:
GEMFILE: gemfiles/rails.5.2.activerecord.gemfile
GEMFILE: gemfiles/rails.6.1.activerecord.gemfile
steps:
- rspec-test

rspec-ruby-26-activerecord60:
rspec-ruby-26-mongoid:
docker:
- image: circleci/ruby:2.6
- image: circleci/mongo:4.2.5
- image: docker.elastic.co/elasticsearch/elasticsearch:5.6.7
environment:
<<: *es56-env
working_directory: ~/repo
environment:
GEMFILE: gemfiles/rails.6.0.activerecord.gemfile
GEMFILE: gemfiles/rails.5.2.mongoid.6.4.gemfile
steps:
- rspec-test

rspec-ruby-26-mongoid:
rspec-ruby-27-activerecord52:
docker:
- image: circleci/ruby:2.6
- image: circleci/mongo:4.2.5
- image: circleci/ruby:2.7
- image: docker.elastic.co/elasticsearch/elasticsearch:5.6.7
environment:
<<: *es56-env
working_directory: ~/repo
environment:
GEMFILE: gemfiles/rails.5.1.mongoid.6.3.gemfile
GEMFILE: gemfiles/rails.5.2.activerecord.gemfile
steps:
- rspec-test

rspec-ruby-27-activerecord52:
rspec-ruby-27-activerecord60:
docker:
- image: circleci/ruby:2.7
- image: docker.elastic.co/elasticsearch/elasticsearch:5.6.7
environment:
<<: *es56-env
working_directory: ~/repo
environment:
GEMFILE: gemfiles/rails.5.2.activerecord.gemfile
GEMFILE: gemfiles/rails.6.0.activerecord.gemfile
steps:
- rspec-test

rspec-ruby-27-activerecord60:
rspec-ruby-27-activerecord61:
docker:
- image: circleci/ruby:2.7
- image: docker.elastic.co/elasticsearch/elasticsearch:5.6.7
environment:
<<: *es56-env
working_directory: ~/repo
environment:
GEMFILE: gemfiles/rails.6.0.activerecord.gemfile
GEMFILE: gemfiles/rails.6.1.activerecord.gemfile
steps:
- rspec-test

Expand All @@ -212,6 +198,6 @@ jobs:
<<: *es56-env
working_directory: ~/repo
environment:
GEMFILE: gemfiles/rails.5.1.mongoid.6.3.gemfile
GEMFILE: gemfiles/rails.5.2.mongoid.6.4.gemfile
steps:
- rspec-test
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# master

* Update gemspec dependencies for Rails. Update CI gemfiles and matrix to tests against current LTS Rails versions.

# Version 5.1.0

## Breaking changes
Expand Down
2 changes: 1 addition & 1 deletion chewy.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Gem::Specification.new do |spec| # rubocop:disable BlockLength
spec.add_development_dependency 'method_source'
spec.add_development_dependency 'unparser'

spec.add_dependency 'activesupport', '>= 4.0'
spec.add_dependency 'activesupport', '>= 5.2'
spec.add_dependency 'elasticsearch', '>= 2.0.0'
spec.add_dependency 'elasticsearch-dsl'
end
15 changes: 0 additions & 15 deletions gemfiles/rails.4.0.activerecord.gemfile

This file was deleted.

15 changes: 0 additions & 15 deletions gemfiles/rails.4.1.activerecord.gemfile

This file was deleted.

16 changes: 0 additions & 16 deletions gemfiles/rails.4.2.activerecord.gemfile

This file was deleted.

16 changes: 0 additions & 16 deletions gemfiles/rails.4.2.mongoid.5.2.gemfile

This file was deleted.

16 changes: 0 additions & 16 deletions gemfiles/rails.5.0.mongoid.6.1.gemfile

This file was deleted.

16 changes: 0 additions & 16 deletions gemfiles/rails.5.1.activerecord.gemfile

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

source "https://rubygems.org"

gem "mongoid", "~> 6.3.0"
gem "activesupport", "~> 5.1.0"
gem "activejob", "~> 5.1.0"
gem "mongoid", "~> 6.4.0"
gem "activesupport", "~> 5.2.0"
gem "activejob", "~> 5.2.0"
gem "resque", require: false
gem "shoryuken", require: false
gem "aws-sdk-sqs", require: false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,16 @@

source "https://rubygems.org"

gem "activerecord", "~> 5.0.0"
gem "activesupport", "~> 5.0.0"
gem "activejob", "~> 5.0.0"
gem "activerecord", "~> 6.1.0"
gem "activesupport", "~> 6.1.0"
gem "activejob", "~> 6.1.0"
gem "resque", require: false
gem "shoryuken", require: false
gem "aws-sdk-sqs", require: false
gem "sidekiq", require: false
gem "kaminari-core", "~> 1.1.0", require: false
gem "will_paginate", require: false
gem "parallel", require: false
gem 'rspec_junit_formatter', '~> 0.4.1'

gemspec path: "../"
2 changes: 1 addition & 1 deletion lib/chewy/type/witchcraft.rb
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def brew(object, crutches = nil)
private

def alicorn
@alicorn ||= class_eval <<-RUBY, __FILE__, __LINE__ + 1
@alicorn ||= singleton_class.class_eval <<-RUBY, __FILE__, __LINE__ + 1
-> (locals, object0, crutches) do
#{composed_values(@type.root, 0)}
end
Expand Down