attribute_highlights returns an array of highlights #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthon
force-pushed
the
highlight-as-array
branch
from
ea577f3 to
ac8e710
Compare
AlfonsoUceda
approved these changes
Feb 11, 2021
rabotyaga
approved these changes
Feb 11, 2021
dalthon
force-pushed
the
highlight-as-array
branch
from
fd39c39 to
e17c93a
Compare
rabotyaga
reviewed
Feb 11, 2021
| @@ -2,13 +2,14 @@ | |||
|
|
|||
| ## Bug fixes | |||
|
|
|||
| * [#755](https://github.com/toptal/chewy/pull/755): attribute_highlights returns an array of highlights ([@musaffa][], [@dalthon][]) | |||
There was a problem hiding this comment.
Oh, and this is a kinda change, not a bug fix, right?
rabotyaga
pushed a commit
that referenced
this pull request
Feb 11, 2021
rabotyaga
pushed a commit
that referenced
this pull request
Feb 11, 2021
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
cyucelen
pushed a commit
to cyucelen/chewy
that referenced
this pull request
Jan 28, 2023
Co-authored-by: Ahmad Musaffa <musaffa_csemm@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a rebase of #387
It also, instead of adding breaking change, adds a new method
*_highlightsthat implements new behavior.