Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clear scroll: pass scroll_id in body #796

Merged
merged 1 commit into from
May 11, 2021
Merged

Conversation

rabotyaga
Copy link
Contributor

@rabotyaga rabotyaga commented May 11, 2021

Fix clear scroll: pass scroll_id in body, as passing in path parameters
is deprecated and can overflow http.max_initial_line_length.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • (n/a) Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the changelog if the new code introduces user-observable changes. See changelog entry format for details.

@rabotyaga rabotyaga self-assigned this May 11, 2021
…ters is deprecated and can overflow `http.max_initial_line_length`
@rabotyaga rabotyaga force-pushed the fix-clear-scroll-api branch from d9ffb6e to 70c5421 Compare May 11, 2021 15:24
@rabotyaga rabotyaga marked this pull request as ready for review May 11, 2021 15:25
@rabotyaga rabotyaga merged commit 973e122 into master May 11, 2021
@rabotyaga rabotyaga deleted the fix-clear-scroll-api branch May 11, 2021 15:32
cyucelen pushed a commit to cyucelen/chewy that referenced this pull request Jan 28, 2023
…ters is deprecated and can overflow `http.max_initial_line_length` (toptal#796)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants