-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow asynchronously cleanup journal #857
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konalegi
force-pushed
the
allow-to-asynchronously-delete-journal
branch
4 times, most recently
from
September 19, 2022 14:50
d1c61b0
to
7fcf1c4
Compare
konalegi
force-pushed
the
allow-to-asynchronously-delete-journal
branch
from
September 19, 2022 15:42
7fcf1c4
to
da9bc3c
Compare
barthez
reviewed
Sep 20, 2022
barthez
force-pushed
the
allow-to-asynchronously-delete-journal
branch
2 times, most recently
from
October 6, 2022 14:22
e5c71ee
to
116a2fa
Compare
AlexVPopov
reviewed
Oct 7, 2022
mrzasa
reviewed
Oct 7, 2022
That enables aynchronous journal clean up. Co-Authored-By: Bartek Bulat <bartek@toptal.com> Co-authored-by: Alex Popov <sasho.popov@toptal.com>
barthez
force-pushed
the
allow-to-asynchronously-delete-journal
branch
from
October 7, 2022 13:41
b9946ea
to
916084d
Compare
mrzasa
approved these changes
Oct 7, 2022
kamtop
reviewed
Oct 10, 2022
kamtop
approved these changes
Oct 10, 2022
cyucelen
pushed a commit
to cyucelen/chewy
that referenced
this pull request
Jan 28, 2023
That enables aynchronous journal clean up. Co-Authored-By: Bartek Bulat <bartek@toptal.com> Co-authored-by: Alex Popov <sasho.popov@toptal.com> Co-authored-by: Bartek Bulat <bartek@toptal.com> Co-authored-by: Alex Popov <sasho.popov@toptal.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the cases when we need to remove a large journal we could benefit from using the async execution provided by delete-by-query methods
Usage example
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).