Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow asynchronously cleanup journal #857

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

konalegi
Copy link

@konalegi konalegi commented Sep 19, 2022

For the cases when we need to remove a large journal we could benefit from using the async execution provided by delete-by-query methods

Usage example

rake chewy:journal:clean -- --wait_for_completion=false --requests_per_second=10 --scroll_size=5000

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the changelog if the new code introduces user-observable changes. See changelog entry format for details.

@konalegi konalegi force-pushed the allow-to-asynchronously-delete-journal branch 4 times, most recently from d1c61b0 to 7fcf1c4 Compare September 19, 2022 14:50
@konalegi konalegi marked this pull request as ready for review September 19, 2022 14:59
@konalegi konalegi force-pushed the allow-to-asynchronously-delete-journal branch from 7fcf1c4 to da9bc3c Compare September 19, 2022 15:42
@konalegi konalegi requested review from barthez and mrzasa September 19, 2022 16:09
README.md Outdated Show resolved Hide resolved
lib/chewy/rake_helper.rb Outdated Show resolved Hide resolved
lib/chewy/rake_helper.rb Outdated Show resolved Hide resolved
@konalegi konalegi marked this pull request as draft September 29, 2022 06:01
@barthez barthez force-pushed the allow-to-asynchronously-delete-journal branch 2 times, most recently from e5c71ee to 116a2fa Compare October 6, 2022 14:22
@barthez barthez marked this pull request as ready for review October 6, 2022 14:35
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
That enables aynchronous journal clean up.

Co-Authored-By: Bartek Bulat <bartek@toptal.com>
Co-authored-by: Alex Popov <sasho.popov@toptal.com>
@barthez barthez force-pushed the allow-to-asynchronously-delete-journal branch from b9946ea to 916084d Compare October 7, 2022 13:41
lib/chewy/rake_helper.rb Show resolved Hide resolved
README.md Show resolved Hide resolved
spec/chewy/rake_helper_spec.rb Show resolved Hide resolved
@barthez barthez merged commit 73b2fb1 into master Oct 10, 2022
@barthez barthez deleted the allow-to-asynchronously-delete-journal branch October 10, 2022 11:56
cyucelen pushed a commit to cyucelen/chewy that referenced this pull request Jan 28, 2023
That enables aynchronous journal clean up.

Co-Authored-By: Bartek Bulat <bartek@toptal.com>
Co-authored-by: Alex Popov <sasho.popov@toptal.com>

Co-authored-by: Bartek Bulat <bartek@toptal.com>
Co-authored-by: Alex Popov <sasho.popov@toptal.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants