-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix in mock_elasticsearch_response_sources #861
Conversation
ad8da4c
to
2c2c3ba
Compare
@konalegi do you have time to look at this? |
GitHub actions are stuck, let me try them run first. Not sure why they are not starting. |
@lafeber could you please rebase your branch with the master? |
Also, please provide a changelog entry, so that will be easier to generate a release (example) |
@konalegi I'm sorry this issue disappeared from my radar. I've updated with master and added a changelog entry. |
@lafeber thanks! |
The "_id" is currently the incrementing id from the
each_with_index
loop. However, this id is eventually used in the all_scope_where_ids_in method, where it subsequently fails.If you add
id: ...
to your hits that are passed as a parameter in themock_elasticsearch_response_sources
method, this helper method now works.Fixes #862
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).