-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax allowed elasticsearch
dependency version
#933
Conversation
Any feedback on this direction? |
I'll take a loon on Monday |
yeah, let's try |
@mjankowski can you please rebase pr? |
6fd7031
to
3985833
Compare
Rebased. |
I'm afraid we cannot simply bump the ES version. With elastic search 7.17 all specs are failing |
Hmm, yeah. I had issues getting the full suite to run locally for master branch (ES issue, I think), so had not been able to correctly compare before. I sorted that out and now see passing master but same failures as CI with this PR branch. Looks like something changed with how you access the logger/tracer between versions 7.13.x and 7.14.x. I just pushed another change which:
This passes for me locally. |
Specs are passing, let me try it in our internal projects, if specs there will pass as well, I'll release it. Thanks for the change btw |
yep, works fine, please update changelog as here https://github.com/toptal/chewy/pull/925/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR7 |
Pushed changelog commit. |
Thank you! Merging! |
Saw the comment here - #847 (comment) - which notes that newer 7.x versions of elasticsearch gem allow either Faraday 1.x or 2.x.
This change might be a good stopgap to include in a Chewy 7.x release while work on ES8 support (in Chewy 8) continues on that PR.