Fix intermittent time-based failure in delayed sidekiq spec #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This example was previously failing when it was run at exactly an "even" 10 second increment time. For example, it would fail at "12:00:10", but pass at "12:00:09" and "12:00:11". This leads to intermittent failures on CI (presumably around ~10% of runs). Updated to use a helper method in the spec which more closely mirrors the scheduler code.
|
It seems to be working, with no failure :wohoo: Could you please add the change log info? for instance like this https://github.com/toptal/chewy/pull/933/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR9 |
|
I'll trigger CI 4-5 times to make sure nothing fails, and once you add changelog I'll release it :) |
|
Added changelog commit here as well. I see there may be a DIFFERENT intermittent failure in some of these CI runs (in rake helper spec), but it looks like none so far in the sidekiq one. |
|
Yeah, it's different, related to sidekiq, seems to be not failing |
konalegi
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example was previously failing when it was run at exactly an "even" 10 second increment time. For example, it would fail at "12:00:10", but pass at "12:00:09" and "12:00:11". This leads to intermittent failures on CI (presumably around ~10% of runs).
Updated to use a helper method in the spec which more closely mirrors the scheduler code.
I noticed this during the CI runs from the previous PR ... and was able to verify this pattern by setting a specific time target for the
Timecop.freezeline, which confirmed the pattern of fail/pass.