close #430 Ensure any specified filename is shortened to the maximum …

…length supported by the OS
torakiki · Mar 9, 2024 · a331e8b · a331e8b
1 parent 8b3a1d6
commit a331e8b
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/...c/main/java/org/sejda/model/parameter/base/MultiplePdfSourceMultipleOutputParameters.java b/...c/main/java/org/sejda/model/parameter/base/MultiplePdfSourceMultipleOutputParameters.java
@@ -124,6 +124,7 @@ public String getSpecificResultFilename(int fileNumber, String expectedExtension
                         }
                         return n;
                     })
+                    .map(IOUtils::shortenFilename)
                     .orElse(null);
         }
         return null;

diff --git a/sejda-sambox/src/test/java/org/sejda/impl/sambox/SplitByPageNumbersSamboxTaskTest.java b/sejda-sambox/src/test/java/org/sejda/impl/sambox/SplitByPageNumbersSamboxTaskTest.java
@@ -19,6 +19,7 @@
  */
 package org.sejda.impl.sambox;
 
+import org.apache.commons.lang3.StringUtils;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 import org.sejda.model.optimization.OptimizationPolicy;
@@ -238,6 +239,24 @@ public void specificResultFilenames_invalidCharacters() throws IOException {
         testContext.assertOutputContainsFilenames("pathtosomewhere.pdf", "`&aaa.pdf", "3_medium-test-file.pdf");
     }
 
+    @Test
+    public void specificResultFilenames_tooLong() throws IOException {
+        setUpParameters();
+        parameters.addSource(mediumInput());
+        parameters.addPage(1);
+        parameters.addPage(2);
+
+        String longfilename = StringUtils.repeat("abcde012345", 200) + ".pdf";
+        parameters.addSpecificResultFilename(longfilename);
+
+        execute(parameters);
+
+        testContext.assertTaskCompleted();
+        testContext.assertOutputSize(3);
+        testContext.assertOutputContainsFilenames("abcde012345abcde012345abcde012345abcde012345abcde012345abcde012345abcde012345abcde012345abcde012345abcde012345abcde012345abcde012345abcde012345abcde012345abcde012345abcde012345abcde012345abcde012345abcde012345abcde012345abcde012345abcde012345abcde0123.pdf", 
+                "2_medium-test-file.pdf", "3_medium-test-file.pdf");
+    }
+
     @Test
     public void sharedResourcesAreNotPurged() throws IOException {
         setUpParameters();