Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor date getters #109

Merged
merged 3 commits into from
Dec 9, 2021
Merged

Refactor date getters #109

merged 3 commits into from
Dec 9, 2021

Conversation

nickmoreton
Copy link
Collaborator

@nickmoreton nickmoreton commented Dec 8, 2021 •
edited
Loading

An alternative XML to import from has missing date fields

if wp:post_modified_gmt is not available in the XML return wp:post_date_gmt

Issue: #108

  • Testing
    • CI passes
    • If necessary, tests are added for new or fixed behaviour
    • These changes do not reduce test coverage
  • Documentation.
    • Documentation changes are not necessary because: the usage has not changed

@nickmoreton
refactor date getters
b16ca14 
if post_modified_gmt is not available in the XML return wp:post_date_gmt
@nickmoreton nickmoreton linked an issue Dec 8, 2021 that may be closed by this pull request
Testing with Wordpress Theme Unit Test Data #108
Closed
@nickmoreton nickmoreton self-assigned this Dec 8, 2021
@nickmoreton
alter xml fixture
4daec4f 
Item with title: Item two title is not currently used in other tests.

Change the date fields to remove the wp:post_modified and post_modified_gmt
@nickmoreton
add a test for new date getters
be81a9b 
This test that the refactored date getters still return a date
nimasmi
nimasmi approved these changes Dec 9, 2021
View reviewed changes
Copy link
Collaborator

@nimasmi nimasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My name is Nick Smith, and I approve of these changes.

@nickmoreton nickmoreton merged commit 4081cbc into main Dec 9, 2021
@nickmoreton nickmoreton deleted the feature/date-fields-update branch December 9, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimasmi nimasmi nimasmi approved these changes

Assignees

@nickmoreton nickmoreton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing with Wordpress Theme Unit Test Data
2 participants
@nickmoreton @nimasmi