Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect some test cases in the same TestCase class #111

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Collect some test cases in the same TestCase class #111

merged 1 commit into from
Dec 13, 2021

Conversation

nimasmi
Copy link
Collaborator

@nimasmi nimasmi commented Dec 13, 2021

This collects the various custom prefilter TestCase classes together, as one class with many methods.

nickmoreton
nickmoreton approved these changes Dec 13, 2021
View reviewed changes
Copy link
Collaborator

@nickmoreton nickmoreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank Nick looks good to me. It does work then.

I wonder if I just gave up too soon :)

@nimasmi nimasmi merged commit 84903fd into fix/107-config-overrides Dec 13, 2021
@nimasmi
Copy link
Collaborator Author

nimasmi commented Dec 13, 2021

I wonder if I just gave up too soon :)

Yeah. Or I may have described it differently. 🤷

@nimasmi nimasmi deleted the fix/107-config-overrides-refactor branch December 13, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickmoreton nickmoreton nickmoreton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nimasmi @nickmoreton