Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Wagtail 3.0 #157

Merged
merged 18 commits into from
Oct 27, 2022
Merged

Update for Wagtail 3.0 #157

merged 18 commits into from
Oct 27, 2022

Conversation

nickmoreton
Copy link
Collaborator

@nickmoreton nickmoreton commented May 20, 2022

Update for Wagtail v3.0

Following the release of Wagtail 3.0 this work implements the changes required for 3.0 compatibility and also maintains backwards compatibility to >= 2.15

  • Testing
    • CI passes
    • If necessary, tests are added for new or fixed behaviour
    • These changes do not reduce test coverage
  • Documentation.
    • This PR adds or updates documentation
    • Documentation changes are not necessary because:

I will be testing this on a live setup as well and will update here.

@nickmoreton nickmoreton changed the title Wagtail 3.0 Update for Wagtail 3.0 May 20, 2022
@nickmoreton nickmoreton marked this pull request as ready for review May 20, 2022 10:34
@nickmoreton nickmoreton self-assigned this May 20, 2022
@nickmoreton nickmoreton added the enhancement New feature or request label May 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2022

Codecov Report

Merging #157 (812df4c) into main (9b07de5) will decrease coverage by 0.49%.
The diff coverage is 74.28%.

@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
- Coverage   65.05%   64.56%   -0.50%     
==========================================
  Files          32       28       -4     
  Lines        1265     1253      -12     
  Branches      228      203      -25     
==========================================
- Hits          823      809      -14     
+ Misses        400      398       -2     
- Partials       42       46       +4     
Impacted Files Coverage Δ
wagtail_wordpress_import/block_builder_defaults.py 84.47% <ø> (ø)
...gtail_wordpress_import/handle_inline_shortcodes.py 88.23% <ø> (ø)
wagtail_wordpress_import/importers/apps.py 0.00% <ø> (ø)
...import/management/commands/analyze_html_content.py 0.00% <ø> (ø)
..._import/management/commands/analyze_xml_content.py 0.00% <0.00%> (ø)
...mport/management/commands/delete_imported_pages.py 0.00% <0.00%> (ø)
...wordpress_import/management/commands/import_xml.py 93.93% <ø> (+0.18%) ⬆️
...wordpress_import/management/commands/reduce_xml.py 33.33% <0.00%> (+1.02%) ⬆️
...gtail_wordpress_import/prefilters/bleach_filter.py 66.66% <ø> (-1.52%) ⬇️
...ordpress_import/prefilters/linebreaks_wp_filter.py 57.44% <ø> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

setup.py Outdated Show resolved Hide resolved
Thanks that seems reasonable to me :)

Co-authored-by: Fabien Le Frapper <contact@fabienlefrapper.me>
@nickmoreton
Copy link
Collaborator Author

nickmoreton commented Sep 9, 2022

Hey @nimasmi Hope you don't mind me nudging about the review here. I'm thinking we'll need to get an update for Wagtail 4 soon 😄 Cheers

This can be useful to a quick spin up of the Wagtail 3 upgrade: https://github.com/nickmoreton/wwi-docker-develop/tree/test-wagtail-3.0

Copy link
Collaborator

@nimasmi nimasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great Nick.

Praise:

  • adding the linters is a good step forward
  • it looks like your multiple version support is neat and maintainable, and removable when we need to
  • good effort including multiple version support in the documentation too

README.md Outdated Show resolved Hide resolved
docs/blockbuilder.md Outdated Show resolved Hide resolved
example/migrations/0001_initial.py Show resolved Hide resolved
example/models.py Outdated Show resolved Hide resolved
@nickmoreton
Copy link
Collaborator Author

Thanks @nimasmi for the code review.

I'll get this merged and release as soon as I can.

@nickmoreton nickmoreton merged commit 26deb7f into main Oct 27, 2022
@nickmoreton nickmoreton deleted the wagtail-3.0 branch October 27, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants