-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for Wagtail 3.0 #157
Conversation
older python versions
allow wagtail >=3.0,<4.0
Changes to be committed: modified: README.md modified: docs/blockbuilder.md
Codecov Report
@@ Coverage Diff @@
## main #157 +/- ##
==========================================
- Coverage 65.05% 64.56% -0.50%
==========================================
Files 32 28 -4
Lines 1265 1253 -12
Branches 228 203 -25
==========================================
- Hits 823 809 -14
+ Misses 400 398 -2
- Partials 42 46 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Thanks that seems reasonable to me :) Co-authored-by: Fabien Le Frapper <contact@fabienlefrapper.me>
Hey @nimasmi Hope you don't mind me nudging about the review here. I'm thinking we'll need to get an update for Wagtail 4 soon 😄 Cheers This can be useful to a quick spin up of the Wagtail 3 upgrade: https://github.com/nickmoreton/wwi-docker-develop/tree/test-wagtail-3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great Nick.
Praise:
- adding the linters is a good step forward
- it looks like your multiple version support is neat and maintainable, and removable when we need to
- good effort including multiple version support in the documentation too
Co-authored-by: Nick Smith <nick.smith@torchbox.com>
for flake8 complaints. I like it :)
Thanks @nimasmi for the code review. I'll get this merged and release as soon as I can. |
Update for Wagtail v3.0
Following the release of Wagtail 3.0 this work implements the changes required for 3.0 compatibility and also maintains backwards compatibility to >= 2.15
I will be testing this on a
live
setup as well and will update here.