Use switching function for Coulomb prior #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the test failure was caused by #286. It's also failing on the main branch. |
|
Fixed in main now |
|
Looks good to me. This invalidates checkpoints using the Coulomb prior. I get that it is for the better but it is starting to happen a lot. |
|
I added the versioning functionality in #288 |
|
I don't think anyone has ever used the Coulomb prior. It just didn't work very well. I wouldn't worry about breaking compatibility with it. |
|
Tests are passing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally I scaled the Coulomb prior by$\text{erfc}(\alpha r)$ to reduce its effect at short distances. It turned out this didn't work well because it was still too short ranged. Even at distances of only 1-2 A there was already a large component of Coulomb energy. I changed it to a cosine switching function which works much better.