Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tornado version and version_info inconsistent #3406

Closed
willATgithub opened this issue Jun 17, 2024 · 2 comments · Fixed by #3410
Closed

Tornado version and version_info inconsistent #3406

willATgithub opened this issue Jun 17, 2024 · 2 comments · Fixed by #3410

Comments

@willATgithub
Copy link

The reported version is 6.4.1 however version_info is reported as (6,4,0,1). This is not consistent with how the version is reported in previous releases.
@bdarnell
Copy link
Member

Oops. I was just thinking that this part of the release process was too manual. ;-) How do you use these fields? Is there a good reason to fix it quickly or is it just something to get right next time?

@willATgithub
Copy link
Author

willATgithub commented Jun 20, 2024 via email

bdarnell added a commit to bdarnell/tornado that referenced this issue Jun 28, 2024
@bdarnell
test: Verify that tornado.version and version_info match
6b23fbc 
These two values should always match, but they're updated
manually so test to catch mistakes.

Closes tornadoweb#3406
@bdarnell bdarnell mentioned this issue Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Verify that tornado.version and version_info match bdarnell/tornado
2 participants
@bdarnell @willATgithub