Fixed Binary-unsafe 'fopen(...)' usage (#84)

torrentpier · Mar 31, 2023 · 1b935b8 · 1b935b8
1 parent c9bcb37
commit 1b935b8
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/admin/admin_attachments.php b/admin/admin_attachments.php
@@ -252,7 +252,7 @@
 
 	if (!$error)
 	{
-		if ( !($fp = @fopen($upload_dir . '/0_000000.000', 'w')) )
+		if ( !($fp = @fopen($upload_dir . '/0_000000.000', 'wb')) )
 		{
 			$error = TRUE;
 			$error_msg = sprintf($lang['DIRECTORY_NOT_WRITEABLE'], $attach_config['upload_dir']) . '<br />';
@@ -441,7 +441,7 @@
 
 	if (!$error)
 	{
-		if ( !($fp = @fopen($upload_dir . '/0_000000.000', 'w')) )
+		if ( !($fp = @fopen($upload_dir . '/0_000000.000', 'wb')) )
 		{
 			$error = TRUE;
 			$error_msg = sprintf($lang['DIRECTORY_NOT_WRITEABLE'], $upload_dir) . '<br />';

diff --git a/library/includes/classes/emailer.php b/library/includes/classes/emailer.php
@@ -110,7 +110,7 @@ function use_template ($template_file, $template_lang = '')
 				}
 			}
 
-			if (!($fd = @fopen($tpl_file, 'r')))
+			if (!($fd = @fopen($tpl_file, 'rb')))
 			{
 				bb_die('Failed opening template file :: ' . $tpl_file);
 			}

diff --git a/library/includes/functions_atom.php b/library/includes/functions_atom.php
@@ -179,7 +179,7 @@ function create_atom ($file_path, $mode, $id, $title, $topics)
 	}
 	$atom .= "</feed>";
 	@unlink($file_path);
-	$fp = fopen($file_path, "w");
+	$fp = fopen($file_path, "wb");
 	fwrite($fp, $atom);
 	fclose ($fp);
 	return true;

diff --git a/library/includes/functions_torrent.php b/library/includes/functions_torrent.php
@@ -268,7 +268,7 @@ function tracker_register ($attach_id, $mode = '', $tor_status = TOR_NOT_APPROVE
 	if ($bb_cfg['bt_disable_dht'])
 	{
 		$tor['info']['private'] = (int) 1;
-		$fp = fopen($filename, 'w+');
+		$fp = fopen($filename, 'wb+');
 		fwrite ($fp, bencode($tor));
 		fclose ($fp);
 	}