Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the pylint plugin to latest astroid version #1708

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

Quasar6X
Copy link
Contributor

The pylint plugin is now working with the latest pylint version 3.2.7

Motivation and Context

The current version of the pylint plugin does not work and pylint raises a warning that it was unable to load it.

How Has This Been Tested?

I've run pylint on a local project of mine with tortoise-orm installed and it picks up the plugin without any warnings.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Quasar6X Quasar6X changed the title Update the pylint plugin to latest astro version Update the pylint plugin to latest astroid version Sep 11, 2024
@Quasar6X Quasar6X force-pushed the update-pylint-plugin branch from fdef123 to ac30c84 Compare September 11, 2024 22:34
@abondar
Copy link
Member

abondar commented Sep 26, 2024

Hi!

Can you please rebase on new develop, previous commit had faulty version of mssql there, so CI was failing

* The pylint plugin is now working with the latest pylint version 3.2.7
@Quasar6X Quasar6X force-pushed the update-pylint-plugin branch from ac30c84 to 1053fff Compare October 1, 2024 13:36
@Quasar6X
Copy link
Contributor Author

Quasar6X commented Oct 1, 2024

Hi!

Thanks for the heads up. I haven't been available up until today, we'd had a team building event, excuse me for my late follow-up.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11126528411

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 89.001%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tortoise/contrib/pylint/init.py 0 3 0.0%
Totals Coverage Status
Change from base Build 11092526693: 0.01%
Covered Lines: 5973
Relevant Lines: 6596

💛 - Coveralls

@abondar abondar merged commit 4a8b3d2 into tortoise:develop Oct 2, 2024
7 checks passed
@Quasar6X Quasar6X deleted the update-pylint-plugin branch October 2, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants