when USE_TZ=False, datetimes must be timezone naive #787
+31
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the USE_TZ setting to control whether Tortoise is dealing with timezone aware or timezone naive datetimes.
When USE_TZ=False, all datetimes should be timezone naive.
When USE_TZ=True, all datetimes should be timezone aware, with the timezone being specified by the TIMEZONE setting.
Motivation and Context
Currently, USE_TZ is a misnomer. It suggests you can either use TZ aware datetimes, or you can use TZ naive datetimes. It's implementation does something different - all datetimes are aware, but in USE_TZ=False they are UTC.
This makes the USE_TZ setting useless, as
USE_TZ=False
==USE_TZ=True, TIMEZONE=UTC
.#631
How Has This Been Tested?
Checklist: