Skip to content

Commit

Permalink
x86, boot: Carve out early cmdline parsing function
Browse files Browse the repository at this point in the history
Carve out early cmdline parsing function into .../lib/cmdline.c so it
can be used by early code in the kernel proper as well.

Adapted from arch/x86/boot/cmdline.c.

Signed-off-by: Borislav Petkov <bp@suse.de>
Link: http://lkml.kernel.org/r/1400525957-11525-2-git-send-email-bp@alien8.de
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
  • Loading branch information
suryasaimadhu authored and H. Peter Anvin committed May 21, 2014
1 parent d6d211d commit 1b1ded5
Show file tree
Hide file tree
Showing 3 changed files with 91 additions and 1 deletion.
6 changes: 6 additions & 0 deletions arch/x86/include/asm/cmdline.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#ifndef _ASM_X86_CMDLINE_H
#define _ASM_X86_CMDLINE_H

int cmdline_find_option_bool(const char *cmdline_ptr, const char *option);

#endif /* _ASM_X86_CMDLINE_H */
2 changes: 1 addition & 1 deletion arch/x86/lib/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ clean-files := inat-tables.c

obj-$(CONFIG_SMP) += msr-smp.o cache-smp.o

lib-y := delay.o misc.o
lib-y := delay.o misc.o cmdline.o
lib-y += thunk_$(BITS).o
lib-y += usercopy_$(BITS).o usercopy.o getuser.o putuser.o
lib-y += memcpy_$(BITS).o
Expand Down
84 changes: 84 additions & 0 deletions arch/x86/lib/cmdline.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
/*
* This file is part of the Linux kernel, and is made available under
* the terms of the GNU General Public License version 2.
*
* Misc librarized functions for cmdline poking.
*/
#include <linux/kernel.h>
#include <linux/string.h>
#include <linux/ctype.h>
#include <asm/setup.h>

static inline int myisspace(u8 c)
{
return c <= ' '; /* Close enough approximation */
}

/**
* Find a boolean option (like quiet,noapic,nosmp....)
*
* @cmdline: the cmdline string
* @option: option string to look for
*
* Returns the position of that @option (starts counting with 1)
* or 0 on not found.
*/
int cmdline_find_option_bool(const char *cmdline, const char *option)
{
char c;
int len, pos = 0, wstart = 0;
const char *opptr = NULL;
enum {
st_wordstart = 0, /* Start of word/after whitespace */
st_wordcmp, /* Comparing this word */
st_wordskip, /* Miscompare, skip */
} state = st_wordstart;

if (!cmdline)
return -1; /* No command line */

len = min_t(int, strlen(cmdline), COMMAND_LINE_SIZE);
if (!len)
return 0;

while (len--) {
c = *(char *)cmdline++;
pos++;

switch (state) {
case st_wordstart:
if (!c)
return 0;
else if (myisspace(c))
break;

state = st_wordcmp;
opptr = option;
wstart = pos;
/* fall through */

case st_wordcmp:
if (!*opptr)
if (!c || myisspace(c))
return wstart;
else
state = st_wordskip;
else if (!c)
return 0;
else if (c != *opptr++)
state = st_wordskip;
else if (!len) /* last word and is matching */
return wstart;
break;

case st_wordskip:
if (!c)
return 0;
else if (myisspace(c))
state = st_wordstart;
break;
}
}

return 0; /* Buffer overrun */
}

0 comments on commit 1b1ded5

Please sign in to comment.