Skip to content

Commit

Permalink
i2c: mux: mlxcpld: Extend driver to support word address space devices
Browse files Browse the repository at this point in the history
Extend driver to allow I2C routing control through CPLD devices with
word address space. Till now only CPLD devices with byte address space
have been supported.

Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
Reviewed-by: Michael Shych <michaelsh@nvidia.com>
Acked-by: Peter Rosin <peda@axentia.se>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
  • Loading branch information
vadimp-nvidia authored and wsakernel committed Feb 9, 2021
1 parent cae5216 commit c52a1c5
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 8 deletions.
47 changes: 39 additions & 8 deletions drivers/i2c/muxes/i2c-mux-mlxcpld.c
Original file line number Diff line number Diff line change
Expand Up @@ -63,19 +63,39 @@ static int mlxcpld_mux_reg_write(struct i2c_adapter *adap,
struct mlxcpld_mux *mux, u32 val)
{
struct i2c_client *client = mux->client;
union i2c_smbus_data data = { .byte = val };

return __i2c_smbus_xfer(adap, client->addr, client->flags,
I2C_SMBUS_WRITE, mux->pdata.sel_reg_addr,
I2C_SMBUS_BYTE_DATA, &data);
union i2c_smbus_data data;
struct i2c_msg msg;
u8 buf[3];

switch (mux->pdata.reg_size) {
case 1:
data.byte = val;
return __i2c_smbus_xfer(adap, client->addr, client->flags,
I2C_SMBUS_WRITE, mux->pdata.sel_reg_addr,
I2C_SMBUS_BYTE_DATA, &data);
case 2:
buf[0] = mux->pdata.sel_reg_addr >> 8;
buf[1] = mux->pdata.sel_reg_addr;
buf[2] = val;
msg.addr = client->addr;
msg.buf = buf;
msg.len = mux->pdata.reg_size + 1;
msg.flags = 0;
return __i2c_transfer(adap, &msg, 1);
default:
return -EINVAL;
}
}

static int mlxcpld_mux_select_chan(struct i2c_mux_core *muxc, u32 chan)
{
struct mlxcpld_mux *mux = i2c_mux_priv(muxc);
u32 regval = chan + 1;
u32 regval = chan;
int err = 0;

if (mux->pdata.reg_size == 1)
regval += 1;

/* Only select the channel if its different from the last channel */
if (mux->last_val != regval) {
err = mlxcpld_mux_reg_write(muxc->parent, mux, regval);
Expand Down Expand Up @@ -103,12 +123,23 @@ static int mlxcpld_mux_probe(struct platform_device *pdev)
struct i2c_mux_core *muxc;
struct mlxcpld_mux *data;
int num, err;
u32 func;

if (!pdata)
return -EINVAL;

if (!i2c_check_functionality(client->adapter,
I2C_FUNC_SMBUS_WRITE_BYTE_DATA))
switch (pdata->reg_size) {
case 1:
func = I2C_FUNC_SMBUS_WRITE_BYTE_DATA;
break;
case 2:
func = I2C_FUNC_I2C;
break;
default:
return -EINVAL;
}

if (!i2c_check_functionality(client->adapter, func))
return -ENODEV;

muxc = i2c_mux_alloc(client->adapter, &pdev->dev, CPLD_MUX_MAX_NCHANS,
Expand Down
2 changes: 2 additions & 0 deletions include/linux/platform_data/mlxcpld.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,13 @@
* @chan_ids - channels array
* @num_adaps - number of adapters
* @sel_reg_addr - mux select register offset in CPLD space
* @reg_size: register size in bytes
*/
struct mlxcpld_mux_plat_data {
int *chan_ids;
int num_adaps;
int sel_reg_addr;
u8 reg_size;
};

#endif /* _LINUX_I2C_MLXCPLD_H */

0 comments on commit c52a1c5

Please sign in to comment.