Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds declarations for ToS;DR services #12

Merged
merged 6 commits into from
Apr 2, 2024
Merged

Adds declarations for ToS;DR services #12

merged 6 commits into from
Apr 2, 2024

Conversation

madoleary
Copy link
Contributor

This PR would add the declarations for the services in ToS;DR's database. It would also source terms types from ToS;DR's fork of OTA's terms types.

michielbdejong
michielbdejong approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@michielbdejong michielbdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

@michielbdejong
Copy link
Member

npm run lint is failing with Invalid URL but it's not giving any information about which file or line number contains an Invalid URL so that's impossible to debug now. Let's merge this now and then ask the OTA people for a better way to run their lint tool, and then we'll fix any errors it finds in a follow-up PR.

@madoleary madoleary merged commit 232b92c into main Apr 2, 2024
0 of 6 checks passed
@madoleary madoleary deleted the initial-declarations branch April 2, 2024 10:30
@michielbdejong michielbdejong mentioned this pull request Apr 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michielbdejong michielbdejong michielbdejong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madoleary @michielbdejong