Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flattenObject): add flattenObject for flatten object keys #183

Closed
wants to merge 10 commits into from

Conversation

ngthuongdoan
Copy link

No description provided.

@ngthuongdoan ngthuongdoan requested a review from raon0211 as a code owner July 13, 2024 16:14
Copy link

vercel bot commented Jul 13, 2024

@ngthuongdoan is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@ngthuongdoan
Copy link
Author

Related #142

@raon0211
Copy link
Collaborator

Sorry for the late review. The implementation is a little bit hard for me to read. Please let me some time to add the review (Recently, a lot of pull requests and issues are springing up.)

@raon0211
Copy link
Collaborator

raon0211 commented Jul 19, 2024

Hello, thanks for your pull request! I understand the needs for flattenObject.

Meanwhile, I think we have to implement flattenObject in an other way for these reasons:

  • The current implementation uses lodash, which is what we prohibit, since using lodash from es-toolkit does not make sense.
  • The current implementation is a bit complex to understand, while our core values of the library is simplicity.

Let me work on implementing flattenObject asap in another commit.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.53%. Comparing base (78c0c66) to head (cdcad81).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #183   +/-   ##
=======================================
  Coverage   99.52%   99.53%           
=======================================
  Files         105      106    +1     
  Lines         635      648   +13     
  Branches      123      128    +5     
=======================================
+ Hits          632      645   +13     
  Misses          3        3           

@raon0211
Copy link
Collaborator

Implemented flattenObject in this commit. Thanks for giving us ideas!

3e60443

@raon0211 raon0211 closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants