fix(*): migrate rollup to tsup, support esm correctly, remove *.spec.* for dist #21
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
package.json
Outdated
| "dist/**/*", | ||
| "esm/**/*", | ||
| "*.d.ts" |
There was a problem hiding this comment.
tsup's default use only dist
| ], | ||
| "publishConfig": { | ||
| "access": "public", | ||
| "main": "./dist/index.js", | ||
| "module": "./dist/index.mjs", |
There was a problem hiding this comment.
module field for yarn berry
https://yarnpkg.com/configuration/manifest#module
| "import": "./esm/index.mjs", | ||
| "require": "./dist/index.js" | ||
| "import": { | ||
| "types": "./dist/index.d.mts", |
There was a problem hiding this comment.
*.d.mts is generated by tsup default
|
|
||
| export default defineConfig({ | ||
| format: ['cjs', 'esm'], | ||
| entry: ['src/*.ts', 'src/*/*.ts', '!**/*.{spec,test,test-d}.*'], |
There was a problem hiding this comment.
#19 !**/*.{spec,test,test-d}.*: This prevent that dist contain test files
package.json
Outdated
| "typescript": "^5.4.5", | ||
| "vitest": "^1.5.2" | ||
| }, | ||
| "sideEffects": false, | ||
| "scripts": { | ||
| "prepack": "yarn build", | ||
| "build": "rm -rf dist esm && tsc -p tsconfig.json --declaration --emitDeclarationOnly --declarationDir dist && rollup -c rollup.config.js && ./.scripts/postbuild.sh", | ||
| "build": "tsup", |
Fixed the Node10 resolution in the commit in 755b938. |
Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
Cool! I didn't think about these topics you suggest. Let's try it gradually |
close #19 close #20
@raon0211 In my opinion, This change is fit for your requirement. Review strictly please!